[
https://issues.apache.org/jira/browse/HDDS-1604?focusedWorklogId=249610&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-249610
]
ASF GitHub Bot logged work on HDDS-1604:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/May/19 20:16
Start Date: 28/May/19 20:16
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #866: HDDS-1604.
ContainerReader#initializeUsedBytes leaks DB reference. Co…
URL: https://github.com/apache/hadoop/pull/866#issuecomment-496672252
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 527 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 559 | trunk passed |
| +1 | compile | 264 | trunk passed |
| +1 | checkstyle | 88 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 884 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 166 | trunk passed |
| 0 | spotbugs | 287 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 488 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 471 | the patch passed |
| +1 | compile | 272 | the patch passed |
| +1 | javac | 272 | the patch passed |
| -0 | checkstyle | 41 | hadoop-hdds: The patch generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 676 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 149 | the patch passed |
| +1 | findbugs | 502 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 233 | hadoop-hdds in the patch failed. |
| -1 | unit | 1302 | hadoop-ozone in the patch failed. |
| -1 | asflicense | 57 | The patch generated 17 ASF License warnings. |
| | | 6911 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdds.scm.block.TestBlockManager |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-866/4/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/866 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux e0d1e6b804bb 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / d8b18e8 |
| Default Java | 1.8.0_212 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-866/4/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-866/4/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-866/4/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-866/4/testReport/ |
| asflicense |
https://builds.apache.org/job/hadoop-multibranch/job/PR-866/4/artifact/out/patch-asflicense-problems.txt
|
| Max. process+thread count | 4374 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/container-service U:
hadoop-hdds/container-service |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-866/4/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 249610)
Time Spent: 20m (was: 10m)
> ContainerReader#initializeUsedBytes leaks DB reference
> ------------------------------------------------------
>
> Key: HDDS-1604
> URL: https://issues.apache.org/jira/browse/HDDS-1604
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This was caught by the New ContainerCache with reference counting from
> HDDS-1449. The root cause is an unclosed KeyValueBlockIterator from
> ContainerReader#initializeUsedBytes.
> I will post a patch shortly, which will fix some UT failures exposed by
> -HDDS-1449,- such as TestBCSID#testBCSID, etc.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
