[ 
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850164#comment-16850164
 ] 

Hadoop QA commented on HDFS-13480:
----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m  
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red}  0m  8s{color} 
| {color:red} HDFS-13480 does not apply to trunk. Rebase required? Wrong 
Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | HDFS-13480 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12924067/HDFS-13480.004.patch |
| Console output | 
https://builds.apache.org/job/PreCommit-HDFS-Build/26853/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> RBF: Separate namenodeHeartbeat and routerHeartbeat to different config key
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-13480
>                 URL: https://issues.apache.org/jira/browse/HDFS-13480
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: maobaolong
>            Assignee: maobaolong
>            Priority: Major
>         Attachments: HDFS-13480.001.patch, HDFS-13480.002.patch, 
> HDFS-13480.002.patch, HDFS-13480.003.patch, HDFS-13480.004.patch
>
>
> Now, if i enable the heartbeat.enable, but i do not want to monitor any 
> namenode, i get an ERROR log like:
> {code:java}
> [2018-04-19T14:00:03.057+08:00] [ERROR] 
> federation.router.Router.serviceInit(Router.java 214) [main] : Heartbeat is 
> enabled but there are no namenodes to monitor
> {code}
> and if i disable the heartbeat.enable, we cannot get any mounttable update, 
> because the following logic in Router.javaļ¼š
> {code:java}
> if (conf.getBoolean(
>         RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE,
>         RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE_DEFAULT)) {
>       // Create status updater for each monitored Namenode
>       this.namenodeHeartbeatServices = createNamenodeHeartbeatServices();
>       for (NamenodeHeartbeatService hearbeatService :
>           this.namenodeHeartbeatServices) {
>         addService(hearbeatService);
>       }
>       if (this.namenodeHeartbeatServices.isEmpty()) {
>         LOG.error("Heartbeat is enabled but there are no namenodes to 
> monitor");
>       }
>       // Periodically update the router state
>       this.routerHeartbeatService = new RouterHeartbeatService(this);
>       addService(this.routerHeartbeatService);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to