[ 
https://issues.apache.org/jira/browse/HDFS-14516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850486#comment-16850486
 ] 

Takanobu Asanuma commented on HDFS-14516:
-----------------------------------------

Thanks for the review [~elgoiri]. And thanks for your comment [~ayushtkn]. I 
agree with your opinion.

Actually, the 1st patch has a problem. I thought {{hdfs-site.xml}} is still 
effective for rbf properties but actually it isn't.

The 1st patch loads configuration files in the following order. The latter 
overwrites the same properties.
 # {{core-site.xml}} and {{hdfs-site.xml}}
 # {{hdfs-rbf-default.xml}} (this overwrite all rbf properties by the default 
values.)
 # {{hdfs-rbf-site.xml}}

The 2nd patch doesn't load {{hdfs-rbf-default.xml}}. It won't affect current 
users who use {{hdfs-site.xml}} for rbf properties. So it keeps compatibility.

> RBF: Create hdfs-rbf-site.xml for RBF specific properties
> ---------------------------------------------------------
>
>                 Key: HDFS-14516
>                 URL: https://issues.apache.org/jira/browse/HDFS-14516
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: rbf
>            Reporter: Takanobu Asanuma
>            Assignee: Takanobu Asanuma
>            Priority: Major
>         Attachments: HDFS-14516.1.patch, HDFS-14516.2.patch
>
>
> Currently, users write rbf properties in {{hdfs-site.xml}} though the 
> definitions are in {{hdfs-rbf-default.xml}}. Like other modules, it would be 
> better if there is a specific configuration file, {{hdfs-rbf-site.xml}}.
> {{hdfs-rbf-default.xml}} also should be loaded when it exists in the 
> configuration directory. It is just a document at the moment.
> There is an early discussion in HDFS-13215.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to