[ https://issues.apache.org/jira/browse/HDDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850826#comment-16850826 ]
Nilotpal Nandi commented on HDDS-1497: -------------------------------------- Thanks [~shashikant] for review . I have addressed your comments . Here are inline comments : 1. Please update comments for property, getter and setter functions. - done 2.cluster.py:223-224 : > incorrect comments. - done 3. clusterUtils.py:324 -> "om_1" should be "om"? - This should work fine with 'om_1" too. "om_1" string is present in om's container name. 4.cluster_utils.py:296 -> which file checksum is it supposed to compute ? can you please update the comments? - done > Refactor blockade Tests > ----------------------- > > Key: HDDS-1497 > URL: https://issues.apache.org/jira/browse/HDDS-1497 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Reporter: Nilotpal Nandi > Assignee: Nilotpal Nandi > Priority: Major > Attachments: HDDS-1497.001.patch, HDDS-1497.002.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org