[
https://issues.apache.org/jira/browse/HDFS-14513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851115#comment-16851115
]
Íñigo Goiri commented on HDFS-14513:
------------------------------------
Thanks [~hexiaoqiao] for the detailed description, could you update the JIRA
description with some of this?
Minor comments:
* Avoid the line change in 1014.
* Use log error with the exception.
* Use lambda to build cancelCheckpointFinalizer:
{code}
Runnable cancelCheckpointFinalizer = () ->
try {
deleteCancelledCheckpoint(context.getTxId());
} catch (IOException e) {
LOG.info("FSImageSaver cancel checkpoint threw an exception", e);
}
};
{code}
> FSImage which is saving should be clean while NameNode shutdown
> ---------------------------------------------------------------
>
> Key: HDFS-14513
> URL: https://issues.apache.org/jira/browse/HDFS-14513
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: He Xiaoqiao
> Assignee: He Xiaoqiao
> Priority: Major
> Attachments: HDFS-14513.001.patch, HDFS-14513.002.patch
>
>
> FSImage checkpoint file which is saving could not be clean while NameNode
> shutdown at the same time.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
