[ 
https://issues.apache.org/jira/browse/HDFS-12733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851186#comment-16851186
 ] 

He Xiaoqiao edited comment on HDFS-12733 at 5/29/19 6:36 PM:
-------------------------------------------------------------

To [~elgoiri], Thanks for taking a look.
{quote}Having the local edits in a HA setting might be valuable for some 
scenarios but we are not removing this feature and we are keeping it as 
enabled.{quote}
I am sorry that I do not retrieve the history about this local edits, but after 
dig the implementation, I don't find the local edit will be used any times for 
HA mode. And I also survey practical usages about this, the majority of guys 
disable this local edits using different approaches. Please correct me if I 
missing something.

{quote}The only thing I would question is whether to have 
DFS_NAMENODE_EDITS_LOCAL_WRITE_DISABLE_KEY or 
DFS_NAMENODE_EDITS_LOCAL_WRITE_ENABLE_KEY.{quote}
DFS_NAMENODE_EDITS_LOCAL_WRITE_DISABLE_KEY is OK for me If we keep local edit 
logic and only add switch to disable it.
Thanks again.


was (Author: hexiaoqiao):
To [~elgoiri], Thanks for taking a look.
{quote}Having the local edits in a HA setting might be valuable for some 
scenarios but we are not removing this feature and we are keeping it as 
enabled.{quote}
I am sorry that I do not retrieve the history about this local edits, but after 
dig the implementation, I don't find the local edit will be used any times. And 
I also survey practical usages about this, the majority of guys disable this 
local edits using different approaches. Please correct me if I missing 
something.

{quote}The only thing I would question is whether to have 
DFS_NAMENODE_EDITS_LOCAL_WRITE_DISABLE_KEY or 
DFS_NAMENODE_EDITS_LOCAL_WRITE_ENABLE_KEY.{quote}
DFS_NAMENODE_EDITS_LOCAL_WRITE_DISABLE_KEY is OK for me If we keep local edit 
logic and only add switch to disable it.
Thanks again.

> Option to disable to namenode local edits
> -----------------------------------------
>
>                 Key: HDFS-12733
>                 URL: https://issues.apache.org/jira/browse/HDFS-12733
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode, performance
>            Reporter: Brahma Reddy Battula
>            Assignee: Brahma Reddy Battula
>            Priority: Major
>         Attachments: HDFS-12733-001.patch, HDFS-12733-002.patch, 
> HDFS-12733-003.patch, HDFS-12733.004.patch, HDFS-12733.005.patch
>
>
> As of now, Edits will be written in local and shared locations which will be 
> redundant and local edits never used in HA setup.
> Disabling local edits gives little performance improvement.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to