[
https://issues.apache.org/jira/browse/HDDS-1551?focusedWorklogId=250614&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-250614
]
ASF GitHub Bot logged work on HDDS-1551:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/May/19 23:46
Start Date: 29/May/19 23:46
Worklog Time Spent: 10m
Work Description: hanishakoneru commented on pull request #850:
HDDS-1551. Implement Bucket Write Requests to use Cache and DoubleBuf…
URL: https://github.com/apache/hadoop/pull/850#discussion_r288721948
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/BucketManagerImpl.java
##########
@@ -296,11 +281,7 @@ public OmBucketInfo setBucketProperty(OmBucketArgs args)
throws IOException {
bucketInfoBuilder.setCreationTime(oldBucketInfo.getCreationTime());
OmBucketInfo omBucketInfo = bucketInfoBuilder.build();
-
- if (!isRatisEnabled) {
- commitSetBucketPropertyInfoToDB(omBucketInfo);
- }
- return omBucketInfo;
+ commitSetBucketPropertyInfoToDB(omBucketInfo);
Review comment:
commitSetBucketPropertyInfoToDB() just calls commitCreateBucketInfoToDB()
without any modification. We can directly call commitCreateBucketInfoToDB()
here (and maybe rename it to commitBucketInfoToDB ? ).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 250614)
Time Spent: 4h 50m (was: 4h 40m)
> Implement Bucket Write Requests to use Cache and DoubleBuffer
> -------------------------------------------------------------
>
> Key: HDDS-1551
> URL: https://issues.apache.org/jira/browse/HDDS-1551
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Implement Bucket write requests to use OM Cache, double buffer.
> And also in OM previously we used to Ratis client for communication to Ratis
> server, instead of that use Ratis server API's.
>
> In this Jira will add the changes to implement bucket operations, and
> HA/Non-HA will have a different code path, but once all requests are
> implemented will have a single code path.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
