[
https://issues.apache.org/jira/browse/HDFS-14508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851476#comment-16851476
]
Takanobu Asanuma commented on HDFS-14508:
-----------------------------------------
Uploaded the 1st patch.
* On second thought, creating a common interface may not be proper if we keep
the same interface as NameNode in Router, because that means NameNode interface
is always common. So same as the existing way, I want to keep
NamenodeBeanMetrics to offer NameNode metrics.
* Instead of creating another metrics service, the patch creates a new
bean({{RouterMBean}}) for router specific metrics, and {{FederationMetrics}}
implements it. I think this way is easy and more natural.
* Moved router specific metrics from {{FederationMBean}} to {{RouterMBean}}.
Kindly help to review it.
> RBF: Clean-up and refactor UI components
> ----------------------------------------
>
> Key: HDFS-14508
> URL: https://issues.apache.org/jira/browse/HDFS-14508
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: CR Hota
> Assignee: Takanobu Asanuma
> Priority: Minor
> Attachments: HDFS-14508-HDFS-13891.1.patch
>
>
> Router UI has tags that are not used or incorrectly set. The code should be
> cleaned-up.
> One such example is
> Path :
> (\hadoop-hdfs-project\hadoop-hdfs-rbf\src\main\webapps\router\federationhealth.js)
> {code:java}
> {"name": "routerstat", "url":
> "/jmx?qry=Hadoop:service=NameNode,name=NameNodeStatus"},{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
