[
https://issues.apache.org/jira/browse/HDFS-13654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16851537#comment-16851537
]
Akira Ajisaka commented on HDFS-13654:
--------------------------------------
Thanks [~tasanuma] for the patch. Two comments:
* Would you add {{@Override}} to
TestHttpFSServerWebServerWithRandomSecret#beforeClass?
* In the beforeClass method, you need to handle Windows environment as
HDFS-14049 did.
> Use a random secret when a secret file doesn't exist in HttpFS. This should
> be default.
> ----------------------------------------------------------------------------------------
>
> Key: HDFS-13654
> URL: https://issues.apache.org/jira/browse/HDFS-13654
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: httpfs, security
> Reporter: Pulkit Bhardwaj
> Assignee: Takanobu Asanuma
> Priority: Major
> Attachments: HDFS-13654.1.patch, HDFS-13654.2.patch,
> HDFS-13654.3.patch, HDFS-13654.4.patch
>
>
> {code:java}
> curl -s
> https://raw.githubusercontent.com/apache/hadoop/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/conf/httpfs-signature.secret
>
> hadoop httpfs secret{code}
>
> The "secret" is a known string, it is better to keep this a random string so
> that it is not well known.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
