[
https://issues.apache.org/jira/browse/HDDS-1581?focusedWorklogId=250762&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-250762
]
ASF GitHub Bot logged work on HDDS-1581:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/19 06:41
Start Date: 30/May/19 06:41
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #872: HDDS-1581.
Atleast one of the metadata dir config property must be tagged as REQUIRED
URL: https://github.com/apache/hadoop/pull/872#issuecomment-497223129
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 30 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 658 | trunk passed |
| +1 | compile | 308 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 1894 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 169 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 588 | the patch passed |
| +1 | compile | 292 | the patch passed |
| +1 | javac | 292 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 2 | The patch has no ill-formed XML file. |
| -1 | shadedclient | 1168 | patch has errors when building and testing our
client artifacts. |
| +1 | javadoc | 160 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 250 | hadoop-hdds in the patch passed. |
| -1 | unit | 1563 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 80 | The patch does not generate ASF License warnings. |
| | | 6389 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-872/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/872 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml |
| uname | Linux e13922c9b02a 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed
Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / c1caab4 |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-872/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-872/1/testReport/ |
| Max. process+thread count | 4080 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common U: hadoop-hdds/common |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-872/1/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 250762)
Time Spent: 0.5h (was: 20m)
> Atleast one of the metadata dir config property must be tagged as REQUIRED
> --------------------------------------------------------------------------
>
> Key: HDDS-1581
> URL: https://issues.apache.org/jira/browse/HDDS-1581
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Affects Versions: 0.4.0
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Labels: configuration, pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This issue was discovered while working on HDDS-373 to generate a minimal
> ozone-site.xml with required values.
> {panel:title=ozone-default.xml}
> <property>
> <name>ozone.metadata.dirs</name>
> <value/>
> <tag>OZONE, OM, SCM, CONTAINER, STORAGE</tag>
> <description>
> This setting is the fallback location for SCM, OM and DataNodes
> to store their metadata. This setting may be used in test/PoC clusters
> to simplify configuration.
> For production clusters or any time you care about performance, it is
> recommended that ozone.om.db.dirs, ozone.scm.db.dirs and
> dfs.container.ratis.datanode.storage.dir be configured separately.
> </description>
> </property>
> {panel}
> However, none of the properties listed above are tagged as REQUIRED.
> For starters, as the goal of HDDS-373 is to generate a simple minimal
> ozone-site.xml that can be used to start ozone, I propose that we do either
> of the following:
> 1. Tag ozone.metadata.dirs as REQUIRED
> OR
> 2. Tag ozone.om.db.dirs, ozone.scm.db.dirs and
> dfs.container.ratis.datanode.storage.dir as REQUIRED
> For simplicity, I would prefer option 1 as that is the fallback config. We
> have already stated that for production use, we must defined the granular
> properties instead of relying on this fallback property ozone.metadata.dirs
> As advised by [~xyao], we are going with Option 1 and adding more details to
> description of other metadata related properties that would use
> ozone.metadata.dirs as a fallback.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
