[
https://issues.apache.org/jira/browse/HDDS-1568?focusedWorklogId=250803&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-250803
]
ASF GitHub Bot logged work on HDDS-1568:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/19 08:04
Start Date: 30/May/19 08:04
Worklog Time Spent: 10m
Work Description: elek commented on pull request #868: HDDS-1568 : Add
RocksDB metrics to OM.
URL: https://github.com/apache/hadoop/pull/868#discussion_r288895769
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBStoreBuilder.java
##########
@@ -187,7 +196,13 @@ private DBOptions getDbProfile() {
if (option == null) {
LOG.info("Using default options. {}", dbProfile.toString());
- return dbProfile.getDBOptions();
+ option = dbProfile.getDBOptions();
+ }
+
+ if (!rocksDbStat.equals(OZONE_METADATA_STORE_ROCKSDB_STATISTICS_OFF)) {
Review comment:
I am not familiar with the old issue, but now our classpath is separated
from yarn. We can use any newer rocksdb (but we should use the same versions
for all the hdds/ozone projects)
I think it's safe to use any new rocksdb feature if you think metrics should
be turned on by default...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 250803)
Time Spent: 1.5h (was: 1h 20m)
> Add RocksDB metrics to OM
> -------------------------
>
> Key: HDDS-1568
> URL: https://issues.apache.org/jira/browse/HDDS-1568
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Manager
> Reporter: Siddharth Wagle
> Assignee: Aravindan Vijayan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> RocksDB statistics need to sinked to hadoop-metrics2 for Ozone Manager to
> understand how OM behaves under heavy load.
> Example: "rocksdb.bytes.written"
> https://github.com/facebook/rocksdb/wiki/Statistics
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
