[
https://issues.apache.org/jira/browse/HDFS-14523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wu Weiwei updated HDFS-14523:
-----------------------------
Description:
getNumOfRacks() and getNumOfLeaves() are two high frequencies call methods for
BlockPlacementPolicy, this two methods need to get NetworkTopology read lock,
and get lock in high frequencies call methods may impact the namenode
performance.
This two methods get number of racks and number of leaves just for chooseTarget
calculate, lock in these two methods, you cannot guarantee these two values
will not change in the subsequent calculations.
I think it's safe to remove the read lock from this two methods.
was:
getNumOfRacks() and getNumOfLeaves() are two high frequencies call methods for
BlockPlacementPolicy, this two methods need to get NetworkTopology read lock,
and get lock in frequencies call methods may impact the namenode performance.
This two methods get number of racks and number of leaves just for chooseTarget
calculate, lock in these two methods, you cannot guarantee these two values
will not change in the subsequent calculations.
I think it's safe to remove the read lock from this two methods.
> Remove excess read lock for NetworkToplogy
> ------------------------------------------
>
> Key: HDFS-14523
> URL: https://issues.apache.org/jira/browse/HDFS-14523
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Wu Weiwei
> Assignee: Wu Weiwei
> Priority: Major
> Attachments: HDFS-14523.1.patch
>
>
> getNumOfRacks() and getNumOfLeaves() are two high frequencies call methods
> for BlockPlacementPolicy, this two methods need to get NetworkTopology read
> lock, and get lock in high frequencies call methods may impact the namenode
> performance.
> This two methods get number of racks and number of leaves just for
> chooseTarget calculate, lock in these two methods, you cannot guarantee
> these two values will not change in the subsequent calculations.
> I think it's safe to remove the read lock from this two methods.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
