[
https://issues.apache.org/jira/browse/HDDS-1596?focusedWorklogId=251003&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-251003
]
ASF GitHub Bot logged work on HDDS-1596:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/May/19 15:13
Start Date: 30/May/19 15:13
Worklog Time Spent: 10m
Work Description: elek commented on pull request #861: HDDS-1596. Create
service endpoint to download configuration from SCM
URL: https://github.com/apache/hadoop/pull/861#discussion_r289035338
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/discovery/ConfigurationXmlEntry.java
##########
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdds.discovery;
+
+import javax.xml.bind.annotation.XmlElement;
+
+/**
+ * JAXB representation of one property of a hadoop configuration XML.
+ */
+public class ConfigurationXmlEntry {
+
+ @XmlElement
+ private String name;
+
+ @XmlElement
+ private String value;
Review comment:
We have but:
1.) I am not sure if they should be added to the downloaded file. (Usually
we don't add tag/description to an ozone-site.xml). But it can be useful to add
tags/descriptions to the generated file just to make it easier to identify the
used configuration.
2.) Unfortunately the Configuration class is very limited. AFAIK I can't get
all the available tags (the key set of propertyTagsMap) and I can't see if the
descriptions are loaded at all...
I may be wrong but I think first we should improve the Configuration.java on
trunk, and get a 3.3 hadoop release OR fork more methods from Configuration and
copy them to the OzoneConfiguration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 251003)
Time Spent: 1h (was: 50m)
> Create service endpoint to download configuration from SCM
> ----------------------------------------------------------
>
> Key: HDDS-1596
> URL: https://issues.apache.org/jira/browse/HDDS-1596
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> As written in the design doc (see the parent issue) it was proposed to
> download the configuration from the scm by the other services.
> I propose to create a separated endpoint to provide the ozone configuration.
> /conf can't be used as it contains *all* the configuration and we need only
> the modified configuration.
> The easiest way to implement this feature is:
> * Create a simple rest endpoint which publishes all the configuration
> * Download the configurations to $HADOOP_CONF_DIR/ozone-global.xml during
> the service startup.
> * Add ozone-global.xml as an additional config source (before ozone-site.xml
> but after ozone-default.xml)
> * The download can be optional
> With this approach we keep the support of the existing manual configuration
> (ozone-site.xml has higher priority) but we can download the configuration to
> a separated file during the startup, which will be loaded.
> There is no magic: the configuration file is saved and it's easy to debug
> what's going on as the OzoneConfiguration is loaded from the $HADOOP_CONF_DIR
> as before.
> Possible follow-up steps:
> * Migrate all the other services (recon, s3g) to the new approach. (possible
> newbie jiras)
> * Improve the CLI to define the SCM address. (As of now we use
> ozone.scm.names)
> * Create a service/hostname registration mechanism and autofill some of the
> configuration based on the topology information.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
