[jira] [Commented] (HDFS-13480) RBF: Separate namenodeHeartbeat and routerHeartbeat to different config key

[Ayush Saxena (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HDFS-13480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853213#comment-16853213
 ] 

Ayush Saxena commented on HDFS-13480:
-------------------------------------

Thanx [~elgoiri] for the review.
Have made the said change.
Pls Review!!!

> RBF: Separate namenodeHeartbeat and routerHeartbeat to different config key
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-13480
>                 URL: https://issues.apache.org/jira/browse/HDFS-13480
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: maobaolong
>            Assignee: maobaolong
>            Priority: Major
>         Attachments: HDFS-13480-HDFS-13891-05.patch, 
> HDFS-13480-HDFS-13891-06.patch, HDFS-13480-HDFS-13891-07.patch, 
> HDFS-13480-HDFS-13891-08.patch, HDFS-13480.001.patch, HDFS-13480.002.patch, 
> HDFS-13480.002.patch, HDFS-13480.003.patch, HDFS-13480.004.patch
>
>
> Now, if i enable the heartbeat.enable, but i do not want to monitor any 
> namenode, i get an ERROR log like:
> {code:java}
> [2018-04-19T14:00:03.057+08:00] [ERROR] 
> federation.router.Router.serviceInit(Router.java 214) [main] : Heartbeat is 
> enabled but there are no namenodes to monitor
> {code}
> and if i disable the heartbeat.enable, we cannot get any mounttable update, 
> because the following logic in Router.java：
> {code:java}
> if (conf.getBoolean(
>         RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE,
>         RBFConfigKeys.DFS_ROUTER_HEARTBEAT_ENABLE_DEFAULT)) {
>       // Create status updater for each monitored Namenode
>       this.namenodeHeartbeatServices = createNamenodeHeartbeatServices();
>       for (NamenodeHeartbeatService hearbeatService :
>           this.namenodeHeartbeatServices) {
>         addService(hearbeatService);
>       }
>       if (this.namenodeHeartbeatServices.isEmpty()) {
>         LOG.error("Heartbeat is enabled but there are no namenodes to 
> monitor");
>       }
>       // Periodically update the router state
>       this.routerHeartbeatService = new RouterHeartbeatService(this);
>       addService(this.routerHeartbeatService);
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org