[ 
https://issues.apache.org/jira/browse/HDFS-14508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16853223#comment-16853223
 ] 

Takanobu Asanuma commented on HDFS-14508:
-----------------------------------------

[~elgoiri] [~crh] Thanks for the review and the discussion.

Uploaded the 4th patch.
 * revert registered name to "Hadoop:service=Router,name=FederationState" (This 
fixes the failed tests.)
 * revert deleted methods in {{FederationMBean}} that I moved to 
{{RouterCoreMBean}} in the last patch, and mark @Deprecated. (That means some 
methods in {{FederationMBean}} are same as in {{RouterCoreMBean}}.)

I think this patch keeps current compatibility of {{FederationMBean}} while 
implementing a new bean. How does look that?

> RBF: Clean-up and refactor UI components
> ----------------------------------------
>
>                 Key: HDFS-14508
>                 URL: https://issues.apache.org/jira/browse/HDFS-14508
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: CR Hota
>            Assignee: Takanobu Asanuma
>            Priority: Minor
>         Attachments: HDFS-14508-HDFS-13891.1.patch, 
> HDFS-14508-HDFS-13891.2.patch, HDFS-14508-HDFS-13891.3.patch, 
> HDFS-14508-HDFS-13891.4.patch
>
>
> Router UI has tags that are not used or incorrectly set. The code should be 
> cleaned-up.
> One such example is 
> Path : 
> (\hadoop-hdfs-project\hadoop-hdfs-rbf\src\main\webapps\router\federationhealth.js)
> {code:java}
> {"name": "routerstat", "url": 
> "/jmx?qry=Hadoop:service=NameNode,name=NameNodeStatus"},{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to