[
https://issues.apache.org/jira/browse/HDDS-1624?focusedWorklogId=252103&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-252103
]
ASF GitHub Bot logged work on HDDS-1624:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/19 22:31
Start Date: 31/May/19 22:31
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #882: HDDS-1624 :
Refactor operations inside the bucket lock in OM key write.
URL: https://github.com/apache/hadoop/pull/882#issuecomment-497879689
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 27 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 2 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 24 | Maven dependency ordering for branch |
| +1 | mvninstall | 539 | trunk passed |
| +1 | compile | 281 | trunk passed |
| +1 | checkstyle | 77 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 917 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 168 | trunk passed |
| 0 | spotbugs | 336 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 523 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 29 | Maven dependency ordering for patch |
| +1 | mvninstall | 492 | the patch passed |
| +1 | compile | 291 | the patch passed |
| +1 | javac | 291 | the patch passed |
| -0 | checkstyle | 40 | hadoop-hdds: The patch generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) |
| -0 | checkstyle | 43 | hadoop-ozone: The patch generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 739 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 183 | the patch passed |
| +1 | findbugs | 733 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 239 | hadoop-hdds in the patch failed. |
| -1 | unit | 1776 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 83 | The patch does not generate ASF License warnings. |
| | | 7412 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdds.scm.container.TestReplicationManager |
| | hadoop.ozone.scm.pipeline.TestSCMPipelineMetrics |
| | hadoop.ozone.TestMiniChaosOzoneCluster |
| | hadoop.ozone.client.rpc.TestFailureHandlingByClient |
| | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException |
| | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
| | hadoop.ozone.scm.TestAllocateContainer |
| | hadoop.ozone.scm.TestXceiverClientManager |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/882 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux a4eeedf5e44a 4.4.0-139-generic #165~14.04.1-Ubuntu SMP Wed
Oct 31 10:55:11 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 4cb559e |
| Default Java | 1.8.0_212 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/testReport/ |
| Max. process+thread count | 5196 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/server-scm
hadoop-ozone/ozone-manager U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 252103)
Time Spent: 20m (was: 10m)
> Refactor operations inside the bucket lock in OM key write.
> -----------------------------------------------------------
>
> Key: HDDS-1624
> URL: https://issues.apache.org/jira/browse/HDDS-1624
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager
> Reporter: Aravindan Vijayan
> Assignee: Aravindan Vijayan
> Priority: Critical
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> There are a few steps that are done inside the OM bucket lock that are lock
> invariant and can be done outside the lock. This patch refactors those steps.
> It also adds an isExist API in the metadata store so that we dont need to
> deserialize the byte[] to Object while doing a simple _table.get(key) !=
> null_ check.
> On applying the patch, the OM + SCM (With dummy datanodes) write performance
> improves by around 3 - 6x based on number of existing keys in the OM RocksDB.
> Thanks to [~nandakumar131] who helped with this patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
