[ 
https://issues.apache.org/jira/browse/HDFS-1447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127462#comment-13127462
 ] 

Uma Maheswara Rao G commented on HDFS-1447:
-------------------------------------------

{quote}
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) 
warnings.
{quote}
  Not related to this patch. Filed a separate JIRA HDFS-2449

{quote}
-1 release audit. The applied patch generated 2 release audit warnings (more 
than the trunk's current 0 warnings).
{quote}
 Not related to this patch. Filed a separate JIRa HDFS-2448

Since there is no functional change, not included new tests. There is no test 
failures because of this patch. Above failures are looks unrelated. ( related 
to protocol changes) 

thanks
Uma
                
> Make getGenerationStampFromFile() more efficient, so it doesn't reprocess 
> full directory listing for every block
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-1447
>                 URL: https://issues.apache.org/jira/browse/HDFS-1447
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node
>    Affects Versions: 0.20.2
>            Reporter: Matt Foley
>            Assignee: Matt Foley
>         Attachments: HDFS-1447.patch, Test_HDFS_1447_NotForCommitt.java.patch
>
>
> Make getGenerationStampFromFile() more efficient. Currently this routine is 
> called by addToReplicasMap() for every blockfile in the directory tree, and 
> it walks each file's containing directory on every call. There is a simple 
> refactoring that should make it more efficient.
> This work item is one of four sub-tasks for HDFS-1443, Improve Datanode 
> startup time.
> The fix will probably be folded into sibling task HDFS-1446, which is already 
> refactoring the method that calls getGenerationStampFromFile().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to