[
https://issues.apache.org/jira/browse/HDFS-14356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16854611#comment-16854611
]
Sammi Chen commented on HDFS-14356:
-----------------------------------
[~PhiloHe], If I remembered correctly, pmem_map_file() API is to map the file
to a memory address. Not sure if It can be used to retrieve the mapped address
of a file. You need double check this.
Some comments for 07.patch.
1. isNativePmemCacheLoader -> isNativeLoader, more generic
2. can we just use
"LOG.info("Initializing cache loader:" + this.getClass().getName());
in PmemMappableBlockLoader, so that log statement in
NativePmemMappableBlockLoader can be removed?
3. Although it's not reported in check style, the first line exceeds 80 chars
per line.
{code:java}
LOG.info("Successfully uncached one replica:{} from persistent memory"
+ ", [cached path={}, length={}]", key, cacheFilePath, length);
{code}
It's close to ready now.
> Implement HDFS cache on SCM with native PMDK libs
> -------------------------------------------------
>
> Key: HDFS-14356
> URL: https://issues.apache.org/jira/browse/HDFS-14356
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: caching, datanode
> Reporter: Feilong He
> Assignee: Feilong He
> Priority: Major
> Attachments: HDFS-14356.000.patch, HDFS-14356.001.patch,
> HDFS-14356.002.patch, HDFS-14356.003.patch, HDFS-14356.004.patch,
> HDFS-14356.005.patch, HDFS-14356.006.patch, HDFS-14356.007.patch
>
>
> In this implementation, native PMDK libs are used to map HDFS blocks to SCM.
> To use this implementation, user should build hadoop with PMDK libs by
> specifying a build option. This implementation is only supported on linux
> platform.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
