[
https://issues.apache.org/jira/browse/HDDS-1371?focusedWorklogId=253958&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-253958
]
ASF GitHub Bot logged work on HDDS-1371:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jun/19 19:10
Start Date: 04/Jun/19 19:10
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #703:
HDDS-1371. Download RocksDB checkpoint from OM Leader to Follower.
URL: https://github.com/apache/hadoop/pull/703#discussion_r290402130
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/utils/db/DBCheckpoint.java
##########
@@ -55,4 +55,20 @@
*/
void cleanupCheckpoint() throws IOException;
+ /**
+ * Set the OM Ratis snapshot index corresponding to the OM DB checkpoint.
+ * The snapshot index is the latest snapshot index saved by ratis
+ * snapshots. It is not guaranteed to be the last ratis index applied to
+ * the OM DB state.
+ * @param omRatisSnapshotIndex the saved ratis snapshot index
+ */
+ void setRatisSnapshotIndex(long omRatisSnapshotIndex);
Review comment:
I think this can be called lastTransactionAppliedIndex, so that it will be
easy to understand.
If you think this should be this way, I am fine with it too..
Now after reading the entire patch, I feel this is fine. Otherwise we need
to change this over the entire place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 253958)
Time Spent: 4h 10m (was: 4h)
> Download RocksDB checkpoint from OM Leader to Follower
> ------------------------------------------------------
>
> Key: HDDS-1371
> URL: https://issues.apache.org/jira/browse/HDDS-1371
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> If a follower OM is lagging way behind the leader OM or in case of a restart
> or bootstrapping, a follower OM might need RocksDB checkpoint from the leader
> to catch up with it. This is because the leader might have purged its logs
> after taking a snapshot.
> This Jira aims to add support to download a RocksDB checkpoint from leader
> OM to follower OM through a HTTP servlet. We reuse the DBCheckpoint servlet
> used by Recon server.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
