[ 
https://issues.apache.org/jira/browse/HDDS-1624?focusedWorklogId=254034&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254034
 ]

ASF GitHub Bot logged work on HDDS-1624:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jun/19 21:18
            Start Date: 04/Jun/19 21:18
    Worklog Time Spent: 10m 
      Work Description: hadoop-yetus commented on issue #882: HDDS-1624 : 
Refactor operations inside the bucket lock in OM key write.
URL: https://github.com/apache/hadoop/pull/882#issuecomment-498847529
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | 0 | reexec | 44 | Docker mode activated. |
   ||| _ Prechecks _ |
   | +1 | dupname | 0 | No case conflicting files found. |
   | +1 | @author | 0 | The patch does not contain any @author tags. |
   | +1 | test4tests | 0 | The patch appears to include 2 new or modified test 
files. |
   ||| _ trunk Compile Tests _ |
   | 0 | mvndep | 34 | Maven dependency ordering for branch |
   | +1 | mvninstall | 550 | trunk passed |
   | +1 | compile | 301 | trunk passed |
   | +1 | checkstyle | 83 | trunk passed |
   | +1 | mvnsite | 0 | trunk passed |
   | +1 | shadedclient | 884 | branch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 166 | trunk passed |
   | 0 | spotbugs | 348 | Used deprecated FindBugs config; considering 
switching to SpotBugs. |
   | +1 | findbugs | 544 | trunk passed |
   ||| _ Patch Compile Tests _ |
   | 0 | mvndep | 62 | Maven dependency ordering for patch |
   | +1 | mvninstall | 493 | the patch passed |
   | +1 | compile | 286 | the patch passed |
   | +1 | javac | 286 | the patch passed |
   | +1 | checkstyle | 73 | the patch passed |
   | +1 | mvnsite | 0 | the patch passed |
   | +1 | whitespace | 0 | The patch has no whitespace issues. |
   | +1 | shadedclient | 635 | patch has no errors when building and testing 
our client artifacts. |
   | +1 | javadoc | 155 | the patch passed |
   | +1 | findbugs | 536 | the patch passed |
   ||| _ Other Tests _ |
   | +1 | unit | 235 | hadoop-hdds in the patch passed. |
   | -1 | unit | 1297 | hadoop-ozone in the patch failed. |
   | +1 | asflicense | 42 | The patch does not generate ASF License warnings. |
   | | | 6602 | |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=17.05.0-ce Server=17.05.0-ce base: 
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/3/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hadoop/pull/882 |
   | Optional Tests | dupname asflicense compile javac javadoc mvninstall 
mvnsite unit shadedclient findbugs checkstyle |
   | uname | Linux 2d5973154278 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | personality/hadoop.sh |
   | git revision | trunk / 97607f3 |
   | Default Java | 1.8.0_212 |
   | unit | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/3/artifact/out/patch-unit-hadoop-ozone.txt
 |
   |  Test Results | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/3/testReport/ |
   | Max. process+thread count | 4452 (vs. ulimit of 5500) |
   | modules | C: hadoop-hdds/common hadoop-hdds/server-scm 
hadoop-ozone/ozone-manager U: . |
   | Console output | 
https://builds.apache.org/job/hadoop-multibranch/job/PR-882/3/console |
   | versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
   | Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
   
   
   This message was automatically generated.
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 254034)
    Time Spent: 3h 40m  (was: 3.5h)

> Refactor operations inside the bucket lock in OM key write.
> -----------------------------------------------------------
>
>                 Key: HDDS-1624
>                 URL: https://issues.apache.org/jira/browse/HDDS-1624
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Manager
>            Reporter: Aravindan Vijayan
>            Assignee: Aravindan Vijayan
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 0.5.0
>
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
>
> There are a few steps that are done inside the OM bucket lock that are lock 
> invariant and can be done outside the lock. This patch refactors those steps. 
> It also adds an isExist API in the metadata store so that we dont need to 
> deserialize the byte[] to Object while doing a simple _table.get(key) != 
> null_ check. 
> On applying the patch, the OM + SCM (With dummy datanodes) write performance 
> improves by around 3 - 6x based on number of existing keys in the OM RocksDB. 
> Thanks to [~nandakumar131] who helped with this patch. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to