[
https://issues.apache.org/jira/browse/HDDS-1640?focusedWorklogId=254106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254106
]
ASF GitHub Bot logged work on HDDS-1640:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/19 00:16
Start Date: 05/Jun/19 00:16
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #907: HDDS-1640. Reduce
the size of recon jar file
URL: https://github.com/apache/hadoop/pull/907#issuecomment-498889797
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 35 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 565 | trunk passed |
| +1 | compile | 300 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 1643 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 167 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 483 | the patch passed |
| +1 | compile | 298 | the patch passed |
| +1 | javac | 298 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 1 | The patch has no ill-formed XML file. |
| -1 | shadedclient | 688 | patch has errors when building and testing our
client artifacts. |
| +1 | javadoc | 168 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 238 | hadoop-hdds in the patch passed. |
| -1 | unit | 1578 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 47 | The patch does not generate ASF License warnings. |
| | | 5530 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.ozone.client.rpc.TestCommitWatcher |
| | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
| | hadoop.ozone.client.rpc.TestFailureHandlingByClient |
| | hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-907/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/907 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml |
| uname | Linux 6849da6acad4 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 1a78794 |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-907/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-907/1/testReport/ |
| Max. process+thread count | 3640 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone U: hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-907/1/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254106)
Time Spent: 40m (was: 0.5h)
> Reduce the size of recon jar file
> ---------------------------------
>
> Key: HDDS-1640
> URL: https://issues.apache.org/jira/browse/HDDS-1640
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Recon
> Reporter: Elek, Marton
> Assignee: Vivek Ratnavel Subramanian
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> hadoop-ozone-recon-0.5.0-SNAPSHOT.jar is 73 MB, mainly because the
> node_modules are included (full typescript source, eslint, babel, etc.):
> {code}
> unzip -l hadoop-ozone-recon-0.5.0-SNAPSHOT.jar | grep node_modules | wc
> {code}
> Fix me if I am wrong, but I think node_modules is not required in the
> distribution as the dependencies are already included in the compiled
> javascript files.
> I propose to remove the node_modules from the jar file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
