[
https://issues.apache.org/jira/browse/HDDS-1637?focusedWorklogId=254192&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-254192
]
ASF GitHub Bot logged work on HDDS-1637:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jun/19 05:31
Start Date: 05/Jun/19 05:31
Worklog Time Spent: 10m
Work Description: ChenSammi commented on pull request #904: HDDS-1637.
Fix random test failure TestSCMContainerPlacementRackAware.
URL: https://github.com/apache/hadoop/pull/904#discussion_r290585240
##########
File path:
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/TestSCMContainerPlacementRackAware.java
##########
@@ -82,7 +82,7 @@ public void setup() {
when(nodeManager.getNodeStat(anyObject()))
.thenReturn(new SCMNodeMetric(STORAGE_CAPACITY, 0L, 100L));
when(nodeManager.getNodeStat(datanodes.get(2)))
- .thenReturn(new SCMNodeMetric(STORAGE_CAPACITY, 90L, 10L));
+ .thenReturn(new SCMNodeMetric(STORAGE_CAPACITY, 90L, 20L));
Review comment:
@xiaoyuyao, currently I favor 2. The chooseRandom node logic in
NetworktopologyImpl now only has the information of toplogy. It cannot make
decision which node has enough capacity since it doesn't have the knowledge of
disk free space so far. So I will go with solution 2 now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 254192)
Time Spent: 40m (was: 0.5h)
> Fix random test failure TestSCMContainerPlacementRackAware
> ----------------------------------------------------------
>
> Key: HDDS-1637
> URL: https://issues.apache.org/jira/browse/HDDS-1637
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This has been seen randomly in latest trunk CI, e.g.,
> [https://ci.anzix.net/job/ozone/16980/testReport/org.apache.hadoop.hdds.scm.container.placement.algorithms/TestSCMContainerPlacementRackAware/testFallback/]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
