[
https://issues.apache.org/jira/browse/HDDS-1622?focusedWorklogId=255173&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-255173
]
ASF GitHub Bot logged work on HDDS-1622:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jun/19 15:24
Start Date: 06/Jun/19 15:24
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #918: HDDS-1622 Use
picocli for StorageContainerManager
URL: https://github.com/apache/hadoop/pull/918#issuecomment-499542689
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 48 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| 0 | shelldocs | 0 | Shelldocs was not available. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 5 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 87 | Maven dependency ordering for branch |
| +1 | mvninstall | 565 | trunk passed |
| +1 | compile | 323 | trunk passed |
| +1 | checkstyle | 95 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| -1 | shadedclient | 85 | branch has errors when building and testing our
client artifacts. |
| +1 | javadoc | 183 | trunk passed |
| 0 | spotbugs | 370 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 580 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 35 | Maven dependency ordering for patch |
| +1 | mvninstall | 632 | the patch passed |
| +1 | compile | 410 | the patch passed |
| +1 | javac | 410 | the patch passed |
| -0 | checkstyle | 58 | hadoop-hdds: The patch generated 34 new + 0
unchanged - 0 fixed = 34 total (was 0) |
| -0 | checkstyle | 60 | hadoop-ozone: The patch generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | shellcheck | 28 | There were no new shellcheck issues. |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 1 | The patch has no ill-formed XML file. |
| -1 | shadedclient | 74 | patch has errors when building and testing our
client artifacts. |
| +1 | javadoc | 214 | the patch passed |
| +1 | findbugs | 704 | the patch passed |
||| _ Other Tests _ |
| +1 | unit | 320 | hadoop-hdds in the patch passed. |
| -1 | unit | 2078 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 82 | The patch does not generate ASF License warnings. |
| | | 6958 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestReadRetries |
| | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestKeyInputStream |
| | hadoop.ozone.ozShell.TestOzoneShell |
| | hadoop.ozone.scm.node.TestSCMNodeMetrics |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-918/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/918 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient xml findbugs checkstyle shellcheck shelldocs |
| uname | Linux 65d60504a4e3 4.4.0-143-generic #169~14.04.2-Ubuntu SMP Wed
Feb 13 15:00:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 9fded67 |
| Default Java | 1.8.0_212 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-918/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-918/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-918/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-918/1/testReport/ |
| Max. process+thread count | 4435 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds hadoop-hdds/server-scm hadoop-ozone/common
hadoop-ozone/integration-test U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-918/1/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.4.6 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 255173)
Time Spent: 0.5h (was: 20m)
> Use picocli for StorageContainerManager
> ---------------------------------------
>
> Key: HDDS-1622
> URL: https://issues.apache.org/jira/browse/HDDS-1622
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Stephen O'Donnell
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Recently we switched to use PicoCli with (almost) all of our daemons (eg. s3
> Gateway, Freon, etc.)
> PicoCli has better output, it can generate nice help, and easier to use as
> it's enough to put a few annotations and we don't need to add all the
> boilerplate code to print out help, etc.
> StorageContainerManager and OzoneManager is not yet supported. The previous
> issue was closed HDDS-453 but since then we improved the GenericCli parser
> (eg. in HDDS-1192), so I think we are ready to move.
> The main idea is to create a starter java similar to
> org.apache.hadoop.ozone.s3.Gateway and we can start StorageContainerManager
> from there.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
