[
https://issues.apache.org/jira/browse/HDDS-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857859#comment-16857859
]
Eric Yang edited comment on HDDS-1565 at 6/6/19 4:48 PM:
---------------------------------------------------------
[~elek] A well designed profile should work well with maven life cycle.
Docker-build is synonym to mvn package. Docker-push is synonym to mvn deploy.
Docker trademark policy has called out lower case 'docker' is a fair use of
their name in command line commands.
We don't really need two maven profiles to indicate the different operation to
perform in Maven life cycle. It will only show our inexperience in using maven
deploy as mean to upload Docker image. Nifi, tinkerpop and syncope and other
Apache projects already have established the pattern to use docker profile in
maven. I don't see any reason for us to be unique.
was (Author: eyang):
[~elek] A well designed profile should work well with maven life cycle.
Docker-build is synonym to mvn package. Docker-push is synonym to mvn deploy.
Docker trademark policy has called out lower case 'docke'r is a fair use of
their name in command line commands.
We don't really need two maven profiles to indicate the different operation to
perform in Maven life cycle. It will only show our inexperience in using maven
deploy as mean to upload Docker image. Nifi, tinkerpop and syncope and other
Apache projects already have established the pattern to use docker profile in
maven. I don't see any reason for us to be unique.
> Rename k8s-dev and k8s-dev-push profiles to docker and docker-push
> ------------------------------------------------------------------
>
> Key: HDDS-1565
> URL: https://issues.apache.org/jira/browse/HDDS-1565
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Based on the feedback from [~eyang] I realized that the names of the k8s-dev
> and k8s-dev-push profiles are not expressive enough as the created containers
> can be used not only for kubernetes but can be used together with any other
> container orchestrator.
> I propose to rename them to docker/docker-push.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
