[
https://issues.apache.org/jira/browse/HDFS-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859881#comment-16859881
]
Stephen O'Donnell edited comment on HDFS-13231 at 6/10/19 11:42 AM:
--------------------------------------------------------------------
Editing this comment as I based the earlier information off an old version and
not trunk.
See the attached screen shot "trunk_icons" for the current set of icons. At the
moment, the "entering maintenance" state is displayed with the same icon as the
"In Maintenance" state, which is slightly confusing. However, there is a
separate section below the main table which shows all nodes currently "entering
maintenance".
For decommissioning, a node which is in "decommissioning" state still has no
icon attached to it in the main table, but it listed in the decommissioning
section below (see screen shot called decommissioning_node).
We should certainly add an icon for nodes which are decommissioning. I see two
choices:
1. Simply attach the Decommissioned icon, which is the same as what maintenance
node does although it does not display at a glance that the decommission is
still ongoing.
2. Add two new states, Decommissioning and Entering Maintenance Mode to the key
and then display the same icon as for Decommissioned and In Maintenance mode
but with a different colour, (eg green, indicating the node is still online,
but transitioning its state).
Thoughts?
was (Author: sodonnell):
See the attached screen shot for the current set of icons used. I propose we
should use a green "no entry" symbol for "decommissioning" and a green wrench
icon for "entering maintenance".
This is because the nodes are basically online in these states, but
transitioning to the new state. Therefore it makes sense to use green to
indicate online, and the same icon as for the final state to indicate the
target state.
Ideally I would use amber for the transitioning state, but the final state
icons are already amber in some cases, so unless we want to change existing
colours, I am not sure there are better colours to use.
> Extend visualization for Maintenance Mode under Datanode tab in the NameNode
> UI
> -------------------------------------------------------------------------------
>
> Key: HDFS-13231
> URL: https://issues.apache.org/jira/browse/HDFS-13231
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: datanode, namenode
> Affects Versions: 3.0.1
> Reporter: Haibo Yan
> Assignee: Stephen O'Donnell
> Priority: Major
> Attachments: decommissioning_node.png, trunk_icons.png
>
>
> With HDFS-9391, table view is using css dynamic class name to match the state
> {code:html|title=hadoop/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html}
> <td ng-value="{state}-{name}" class="dfshealth-node-icon
> dfshealth-node-{state}">{name} ({xferaddr})</td>
> {code}
> Some css is missing when the datanode is going to
> {code:javascript|title=hadoop/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js}
> if (n.adminState === "In Service") {
> n.state = "alive";
> } else if (nodes[i].adminState === "Decommission In Progress") {
> n.state = "decommissioning";
> } else if (nodes[i].adminState === "Decommissioned") {
> n.state = "decommissioned";
> } else if (nodes[i].adminState === "Entering Maintenance") {
> n.state = "entering-maintenance";
> } else if (nodes[i].adminState === "In Maintenance") {
> n.state = "in-maintenance";
> }
> {code}
> dfshealth-node-decommissioning, dfshealth-node-entering-maintenance,
> dfshealth-node-in-maintenance should be added into hadoop.css
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
