[ 
https://issues.apache.org/jira/browse/HDFS-13231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16859975#comment-16859975
 ] 

Wei-Chiu Chuang commented on HDFS-13231:
----------------------------------------

Thanks [~sodonnell] for picking this up.
bq. For decommissioning, a node which is in "decommissioning" state still has 
no icon attached to it in the main table, but it listed in the decommissioning 
section below (see screen shot called decommissioning_node).

I think there are two missing parts here. One is that "decommissioning" state 
does not have an icon; the other is that under "In operation" list, the 
decommissioning node is listed, but does not have an icon, unlike an "In 
Service" node.

bq. 2. Add two new states, Decommissioning and Entering Maintenance Mode to the 
key and then display the same icon as for Decommissioned and In Maintenance 
mode but with a different colour, (eg green, indicating the node is still 
online, but transitioning its state).

I prefer this option. I think option 1 is more confusing.


> Extend visualization for Maintenance Mode under Datanode tab in the NameNode 
> UI
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-13231
>                 URL: https://issues.apache.org/jira/browse/HDFS-13231
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode, namenode
>    Affects Versions: 3.0.1
>            Reporter: Haibo Yan
>            Assignee: Stephen O'Donnell
>            Priority: Major
>         Attachments: decommissioning_node.png, trunk_icons.png
>
>
> With HDFS-9391, table view is using css dynamic class name to match the state
> {code:html|title=hadoop/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.html}
> <td ng-value="{state}-{name}" class="dfshealth-node-icon 
> dfshealth-node-{state}">{name} ({xferaddr})</td>
> {code}
> Some css is missing when the datanode is going to 
> {code:javascript|title=hadoop/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js}
>           if (n.adminState === "In Service") {
>             n.state = "alive";
>           } else if (nodes[i].adminState === "Decommission In Progress") {
>             n.state = "decommissioning";
>           } else if (nodes[i].adminState === "Decommissioned") {
>             n.state = "decommissioned";
>           } else if (nodes[i].adminState === "Entering Maintenance") {
>             n.state = "entering-maintenance";
>           } else if (nodes[i].adminState === "In Maintenance") {
>             n.state = "in-maintenance";
>           }
> {code}
> dfshealth-node-decommissioning, dfshealth-node-entering-maintenance, 
> dfshealth-node-in-maintenance should be added into hadoop.css



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to