[
https://issues.apache.org/jira/browse/HDDS-1543?focusedWorklogId=257100&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-257100
]
ASF GitHub Bot logged work on HDDS-1543:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jun/19 19:51
Start Date: 10/Jun/19 19:51
Worklog Time Spent: 10m
Work Description: ajayydv commented on pull request #927: HDDS-1543.
Implement addAcl,removeAcl,setAcl,getAcl for Prefix. Contr…
URL: https://github.com/apache/hadoop/pull/927#discussion_r292163106
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestKeyManagerImpl.java
##########
@@ -323,6 +347,175 @@ public void testOpenFile() throws IOException {
}
}
+
+ @Test
+ public void testPrefixAclOps() throws IOException {
+ String volumeName = "vol1";
+ String bucketName = "bucket1";
+ String prefix1 = "pf1/";
+
+ OzoneObj ozPrefix1 = new OzoneObjInfo.Builder()
+ .setVolumeName(volumeName)
+ .setBucketName(bucketName)
+ .setPrefixName(prefix1)
+ .setResType(OzoneObj.ResourceType.PREFIX)
+ .setStoreType(OzoneObj.StoreType.OZONE)
+ .build();
+
+ OzoneAcl ozAcl1 = new OzoneAcl(ACLIdentityType.USER, "user1",
+ ACLType.READ);
+ prefixManager.addAcl(ozPrefix1, ozAcl1);
+
+ List<OzoneAcl> ozAclGet = prefixManager.getAcl(ozPrefix1);
+ Assert.assertEquals(1, ozAclGet.size());
+ Assert.assertEquals(ozAcl1, ozAclGet.get(0));
+
+ List<OzoneAcl> acls = new ArrayList<>();
+ OzoneAcl ozAcl2 = new OzoneAcl(ACLIdentityType.USER, "admin",
+ ACLType.ALL);
+
+ BitSet aclRights = new BitSet();
+ aclRights.set(IAccessAuthorizer.ACLType.WRITE.ordinal());
+ aclRights.set(IAccessAuthorizer.ACLType.READ.ordinal());
+ OzoneAcl ozAcl3 = new OzoneAcl(ACLIdentityType.GROUP, "dev",
+ aclRights);
+
+ acls.add(ozAcl2);
+ acls.add(ozAcl3);
+
+ prefixManager.setAcl(ozPrefix1, acls);
+ ozAclGet = prefixManager.getAcl(ozPrefix1);
+ Assert.assertEquals(2, ozAclGet.size());
+
+ int matchEntries = 0;
+ for (OzoneAcl acl : ozAclGet) {
+ if (acl.getType() == ACLIdentityType.GROUP) {
+ Assert.assertEquals(ozAcl3, acl);
+ matchEntries++;
+ }
+ if (acl.getType() == ACLIdentityType.USER) {
+ Assert.assertEquals(ozAcl2, acl);
+ matchEntries++;
+ }
+ }
+ Assert.assertEquals(2, matchEntries);
+
+ boolean result = prefixManager.removeAcl(ozPrefix1, ozAcl3);
+ Assert.assertEquals(true, result);
+
+ ozAclGet = prefixManager.getAcl(ozPrefix1);
+ Assert.assertEquals(1, ozAclGet.size());
+
+ Assert.assertEquals(ozAcl2, ozAclGet.get(0));
+ }
+
+ @Test
+ public void testInvalidPrefixAcl() throws IOException {
+ String volumeName = "vol1";
+ String bucketName = "bucket1";
+ String prefix1 = "pf1/";
+
+ // Invalid prefix not ending with "/"
+ String invalidPrefix = "invalid/pf";
+ OzoneAcl ozAcl1 = new OzoneAcl(ACLIdentityType.USER, "user1",
+ ACLType.READ);
+
+ OzoneObj ozInvalidPrefix = new OzoneObjInfo.Builder()
+ .setVolumeName(volumeName)
+ .setBucketName(bucketName)
+ .setPrefixName(invalidPrefix)
+ .setResType(OzoneObj.ResourceType.PREFIX)
+ .setStoreType(OzoneObj.StoreType.OZONE)
+ .build();
+
+ // add acl wiht invalid prefix name
Review comment:
type
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 257100)
Time Spent: 2h 10m (was: 2h)
> Implement addAcl,removeAcl,setAcl,getAcl for Prefix
> ----------------------------------------------------
>
> Key: HDDS-1543
> URL: https://issues.apache.org/jira/browse/HDDS-1543
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Ajay Kumar
> Assignee: Xiaoyu Yao
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Implement addAcl,removeAcl,setAcl,getAcl for Prefix
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
