[
https://issues.apache.org/jira/browse/HDDS-1620?focusedWorklogId=257942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-257942
]
ASF GitHub Bot logged work on HDDS-1620:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/19 17:29
Start Date: 11/Jun/19 17:29
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #884:
HDDS-1620. Implement Volume Write Requests to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/884#discussion_r292575090
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/VolumeRequestHelper.java
##########
@@ -0,0 +1,117 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.request.volume;
+
+import com.google.common.base.Preconditions;
+import org.apache.hadoop.ozone.om.OMMetadataManager;
+import org.apache.hadoop.ozone.om.exceptions.OMException;
+import org.apache.hadoop.ozone.protocol.proto.OzoneManagerProtocolProtos
+ .VolumeList;
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * Helper class for Volume requests.
+ */
+public final class VolumeRequestHelper {
+
+ private VolumeRequestHelper() {
+
+ }
+
+ /**
+ * Delete volume from user list. This method should be called after acquiring
+ * user lock.
+ * @param omMetadataManager
+ * @param volume
+ * @param owner
+ * @return VolumeList - updated volume list for the user.
+ * @throws IOException
+ */
+ public static VolumeList delVolumeFromOwnerList(
+ OMMetadataManager omMetadataManager, String volume, String owner)
+ throws IOException {
+ Preconditions.checkNotNull(omMetadataManager);
+ Preconditions.checkNotNull(volume);
+ Preconditions.checkNotNull(owner);
+ // Get the volume list
+ VolumeList volumeList = omMetadataManager.getUserTable().get(owner);
+
+ List<String> prevVolList = new ArrayList<>();
+ if (volumeList != null) {
+ prevVolList.addAll(volumeList.getVolumeNamesList());
+ } else {
+ throw new OMException(OMException.ResultCodes.USER_NOT_FOUND);
+ }
+
+ // Remove the volume from the list
+ prevVolList.remove(volume);
+ VolumeList newVolList = VolumeList.newBuilder()
+ .addAllVolumeNames(prevVolList).build();
+ return newVolList;
+ }
+
+
+ /**
+ * Add volume to user list. This method should be called after acquiring user
+ * lock.
+ * @param omMetadataManager
+ * @param volume
+ * @param owner
+ * @param maxUserVolumeCount
+ * @return VolumeList - which is updated volume list.
+ * @throws OMException - if user has volumes greater than
+ * maxUserVolumeCount, an exception is thrown.
+ */
+ public static VolumeList addVolumeToOwnerList(
+ OMMetadataManager omMetadataManager, String volume, String owner,
+ long maxUserVolumeCount) throws IOException {
+ Preconditions.checkNotNull(omMetadataManager);
Review comment:
Fixed it. And also changed this class to OMVolumeRequest interface, instead
of helper class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 257942)
Time Spent: 6h 10m (was: 6h)
> Implement Volume Write Requests to use Cache and DoubleBuffer
> -------------------------------------------------------------
>
> Key: HDDS-1620
> URL: https://issues.apache.org/jira/browse/HDDS-1620
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> Implement Volume write requests to use OM Cache, double buffer.
> In this Jira will add the changes to implement volume operations, and
> HA/Non-HA will have a different code path, but once all requests are
> implemented will have a single code path.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
