[ https://issues.apache.org/jira/browse/HDDS-1587?focusedWorklogId=258305&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-258305 ]
ASF GitHub Bot logged work on HDDS-1587: ---------------------------------------- Author: ASF GitHub Bot Created on: 12/Jun/19 03:14 Start Date: 12/Jun/19 03:14 Worklog Time Spent: 10m Work Description: chenjunjiedada commented on pull request #942: HDDS-1587. Support dynamically adding delegated classes from to isolated class loader. URL: https://github.com/apache/hadoop/pull/942#discussion_r292732610 ########## File path: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/FilteredClassLoader.java ########## @@ -57,6 +57,12 @@ public FilteredClassLoader(URL[] urls, ClassLoader parent) { delegatedClasses.add("org.apache.hadoop.fs.ozone.OzoneFSStorageStatistics"); delegatedClasses.add("org.apache.hadoop.fs.ozone.Statistic"); delegatedClasses.add("org.apache.hadoop.fs.Seekable"); + String[] dynamicDelegatedClasses = + System.getProperty("HADOOP_OZONE_DELEGATED_CLASSES").split(";"); + for (String delegatedClass : dynamicDelegatedClasses) { + delegatedClasses.add(delegatedClass); + } Review comment: I see. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 258305) Time Spent: 2h (was: 1h 50m) > Support dynamically adding delegated class to filteredclass loader > ------------------------------------------------------------------ > > Key: HDDS-1587 > URL: https://issues.apache.org/jira/browse/HDDS-1587 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Affects Versions: 0.4.0 > Reporter: Xiaoyu Yao > Assignee: Junjie Chen > Priority: Major > Labels: pull-request-available > Time Spent: 2h > Remaining Estimate: 0h > > HDDS-922 added a filtered class loader with a list of delegated classes that > will be loaded with the app launcher's classloader. With security enabled on > ozone-0.4, there are some incompatible changes from Hadoop-common and > hadoop-auth module from Hadoop-2.x to Hadoop-3.x. Some examples can be seen > HDDS-1080, where the fix has to be made along with a rebuild/release. > > This ticket is opened to allow dynamically adding delegated classes or class > prefix via environment variable. This way, we can easily adjust the setting > in different deployment without rebuild/release. > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org