[
https://issues.apache.org/jira/browse/HDDS-1620?focusedWorklogId=258346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-258346
]
ASF GitHub Bot logged work on HDDS-1620:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/19 04:14
Start Date: 12/Jun/19 04:14
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #884:
HDDS-1620. Implement Volume Write Requests to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/884#discussion_r292740740
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java
##########
@@ -451,6 +456,21 @@ private boolean startsWith(byte[] firstArray, byte[]
secondArray) {
public boolean isVolumeEmpty(String volume) throws IOException {
String volumePrefix = getVolumeKey(volume + OM_KEY_PREFIX);
+ if (bucketTable instanceof TypedTable) {
Review comment:
When bucketTable is not an instance of TypedTable. As only TypedTables have
Cache.
This is more like a safer check, in a case in future if someone changes the
bucketTable to RDBTable, we don't need to do the logic inside this if check.
Because cacheIterator throws NotImplementedException for RDBTable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 258346)
Time Spent: 15h 10m (was: 15h)
> Implement Volume Write Requests to use Cache and DoubleBuffer
> -------------------------------------------------------------
>
> Key: HDDS-1620
> URL: https://issues.apache.org/jira/browse/HDDS-1620
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
> Implement Volume write requests to use OM Cache, double buffer.
> In this Jira will add the changes to implement volume operations, and
> HA/Non-HA will have a different code path, but once all requests are
> implemented will have a single code path.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
