[
https://issues.apache.org/jira/browse/HDDS-1672?focusedWorklogId=258970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-258970
]
ASF GitHub Bot logged work on HDDS-1672:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jun/19 18:00
Start Date: 12/Jun/19 18:00
Worklog Time Spent: 10m
Work Description: anuengineer commented on issue #949: HDDS-1672.
OzoneManager Lock change the volumeLock weight to 0
URL: https://github.com/apache/hadoop/pull/949#issuecomment-501388383
> Thank You @anuengineer for the comments.
> Could you provide a table which has been written when it is first
designed? I can take a look at it, and >see what is meant by locking conflict
resolution table, and see how to come up with such a table, and >see if this is
breaking anything.
I will try to find it, @nandakumar131 and I worked on this together, I
think Nanda wrote that document. These are the kind of docs I wish were
committed it the design repo so that we can find them when we need. I don't
think that doc was posted to Apache, But I will see if I can find it, else we
will have to rebuild that lock conflict table.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 258970)
Time Spent: 50m (was: 40m)
> OzoneManager Lock change the volumeLock weight to 0
> ---------------------------------------------------
>
> Key: HDDS-1672
> URL: https://issues.apache.org/jira/browse/HDDS-1672
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager
> Affects Versions: 0.4.0
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently after acquiring volume lock, we cannot acquire user lock.
> This is causing an issue in Volume request implementation,
> acquire/release/reacquire volume lock.
>
> Case of Delete Volume Request:
> # Acquire volume lock.
> # Get Volume Info from DB
> # Release Volume lock. (We are releasing the lock, because while acquiring
> volume lock, we cannot acquire user lock0
> # Get owner from volume Info read from DB
> # Acquire owner lock
> # Acquire volume lock
> # Do delete logic
> # release volume lock
> # release user lock
>
> We can avoid this acquire/release/reacquire lock issue by making volume lock
> as low weight.
>
> In this way, the above deleteVolume request will change as below
> # Acquire volume lock
> # Get Volume Info from DB
> # Get owner from volume Info read from DB
> # Acquire owner lock
> # Do delete logic
> # release owner lock
> # release volume lock.
> Same issue is seen with SetOwner for Volume request also.
> During HDDS-1620 [~arp] brought up this issue.
> I am proposing the above solution to solve this issue. Any other
> idea/suggestions are welcome.
> This also resolves a bug in setOwner for Volume request.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
