[
https://issues.apache.org/jira/browse/HDDS-1680?focusedWorklogId=259623&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-259623
]
ASF GitHub Bot logged work on HDDS-1680:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Jun/19 14:17
Start Date: 13/Jun/19 14:17
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #961: HDDS-1680. Create
missing parent directories during the creation of HddsVolume dirs
URL: https://github.com/apache/hadoop/pull/961#issuecomment-501722334
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 34 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| +1 | mvninstall | 515 | trunk passed |
| +1 | compile | 284 | trunk passed |
| +1 | checkstyle | 81 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 825 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 157 | trunk passed |
| 0 | spotbugs | 334 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 519 | trunk passed |
||| _ Patch Compile Tests _ |
| +1 | mvninstall | 467 | the patch passed |
| +1 | compile | 294 | the patch passed |
| +1 | javac | 294 | the patch passed |
| +1 | checkstyle | 81 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 672 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 158 | the patch passed |
| +1 | findbugs | 541 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 172 | hadoop-hdds in the patch failed. |
| -1 | unit | 1369 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 61 | The patch does not generate ASF License warnings. |
| | | 6432 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.ozone.container.common.impl.TestHddsDispatcher
|
| | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
| | hadoop.hdds.scm.pipeline.TestSCMPipelineManager |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-961/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/961 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 0f6543094cfe 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 940bcf0 |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-961/1/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-961/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-961/1/testReport/ |
| Max. process+thread count | 4548 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/container-service U:
hadoop-hdds/container-service |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-961/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 259623)
Time Spent: 20m (was: 10m)
> Create missing parent directories during the creation of HddsVolume dirs
> ------------------------------------------------------------------------
>
> Key: HDDS-1680
> URL: https://issues.apache.org/jira/browse/HDDS-1680
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I started to execute all the unit tests continuously (in kubernetes with argo
> workflow).
> Until now I got the following failures (number of failures / unit test name):
> ```
> 1 org.apache.hadoop.fs.ozone.contract.ITestOzoneContractMkdir
> 1 org.apache.hadoop.fs.ozone.contract.ITestOzoneContractRename
> 3
> org.apache.hadoop.hdds.scm.container.placement.algorithms.TestSCMContainerPlacementRackAware
> 31 org.apache.hadoop.ozone.container.common.TestDatanodeStateMachine
> 31 org.apache.hadoop.ozone.container.common.volume.TestVolumeSet
> 1 org.apache.hadoop.ozone.freon.TestDataValidateWithSafeByteOperations
> ```
> TestVolumeSet is also failed locally:
> {code}
> 2019-06-13 14:23:18,637 ERROR volume.VolumeSet
> (VolumeSet.java:initializeVolumeSet(184)) - Failed to parse the storage
> location:
> /home/elek/projects/hadoop/hadoop-hdds/container-service/target/test-dir/dfs
> java.io.IOException: Cannot create directory
> /home/elek/projects/hadoop/hadoop-hdds/container-service/target/test-dir/dfs/hdds
> at
> org.apache.hadoop.ozone.container.common.volume.HddsVolume.initialize(HddsVolume.java:208)
> at
> org.apache.hadoop.ozone.container.common.volume.HddsVolume.<init>(HddsVolume.java:179)
> at
> org.apache.hadoop.ozone.container.common.volume.HddsVolume.<init>(HddsVolume.java:72)
> at
> org.apache.hadoop.ozone.container.common.volume.HddsVolume$Builder.build(HddsVolume.java:156)
> at
> org.apache.hadoop.ozone.container.common.volume.VolumeSet.createVolume(VolumeSet.java:311)
> at
> org.apache.hadoop.ozone.container.common.volume.VolumeSet.initializeVolumeSet(VolumeSet.java:165)
> at
> org.apache.hadoop.ozone.container.common.volume.VolumeSet.<init>(VolumeSet.java:130)
> at
> org.apache.hadoop.ozone.container.common.volume.VolumeSet.<init>(VolumeSet.java:109)
> at
> org.apache.hadoop.ozone.container.common.volume.TestVolumeSet.testFailVolumes(TestVolumeSet.java:232)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at
> org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
> {code}
> The problem here is that the parent directory of the volume dir is missing. I
> propose to use hddsRootDir.mkdirs() instead of hddsRootDir.mkdir() which
> creates the missing parent directories.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
