[
https://issues.apache.org/jira/browse/HDDS-1597?focusedWorklogId=260533&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-260533
]
ASF GitHub Bot logged work on HDDS-1597:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/19 15:54
Start Date: 14/Jun/19 15:54
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #969: HDDS-1597. Remove
hdds-server-scm dependency from ozone-common
URL: https://github.com/apache/hadoop/pull/969#issuecomment-502163167
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 33 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 2 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 23 | Maven dependency ordering for branch |
| +1 | mvninstall | 519 | trunk passed |
| +1 | compile | 285 | trunk passed |
| +1 | checkstyle | 84 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 885 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 181 | trunk passed |
| 0 | spotbugs | 333 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 526 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 35 | Maven dependency ordering for patch |
| +1 | mvninstall | 461 | the patch passed |
| +1 | compile | 291 | the patch passed |
| +1 | javac | 291 | the patch passed |
| +1 | checkstyle | 88 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 1 | The patch has no whitespace issues. |
| +1 | xml | 8 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 663 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 171 | the patch passed |
| +1 | findbugs | 550 | the patch passed |
||| _ Other Tests _ |
| -1 | unit | 127 | hadoop-hdds in the patch failed. |
| -1 | unit | 1260 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 77 | The patch does not generate ASF License warnings. |
| | | 6455 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.ozone.lock.TestLockManager |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
| | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
| | hadoop.hdds.scm.pipeline.TestSCMPipelineManager |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-969/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/969 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml |
| uname | Linux ad3290838c2b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 4f45529 |
| Default Java | 1.8.0_212 |
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-969/1/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-969/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-969/1/testReport/ |
| Max. process+thread count | 4733 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/container-service
hadoop-hdds/framework hadoop-hdds/server-scm hadoop-ozone hadoop-ozone/common
hadoop-ozone/integration-test hadoop-ozone/ozone-manager hadoop-ozone/tools U:
. |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-969/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 260533)
Time Spent: 3h 20m (was: 3h 10m)
> Remove hdds-server-scm dependency from ozone-common
> ---------------------------------------------------
>
> Key: HDDS-1597
> URL: https://issues.apache.org/jira/browse/HDDS-1597
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.4.1
>
> Attachments: ozone-dependency.png
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> I noticed that the hadoop-ozone/common project depends on
> hadoop-hdds-server-scm project.
> The common projects are designed to be a shared artifacts between client and
> server side. Adding additional dependency to the common pom means that the
> dependency will be available for all the clients as well.
> (See the attached artifact about the current, desired structure).
> We definitely don't need scm server dependency on the client side.
> The code dependency is just one class (ScmUtils) and the shared code can be
> easily moved to the common.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
