[
https://issues.apache.org/jira/browse/HDDS-1579?focusedWorklogId=260765&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-260765
]
ASF GitHub Bot logged work on HDDS-1579:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jun/19 23:16
Start Date: 14/Jun/19 23:16
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #871:
HDDS-1579. Create OMDoubleBuffer metrics.
URL: https://github.com/apache/hadoop/pull/871#discussion_r294019380
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/metrics/OzoneManagerDoubleBufferMetrics.java
##########
@@ -0,0 +1,89 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.om.ratis.metrics;
+
+import org.apache.hadoop.metrics2.MetricsSystem;
+import org.apache.hadoop.metrics2.annotation.Metric;
+import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
+import org.apache.hadoop.metrics2.lib.MutableCounterLong;
+
+/**
+ * Class which maintains metrics related to OzoneManager DoubleBuffer.
+ */
+public class OzoneManagerDoubleBufferMetrics {
+
+ private static final String SOURCE_NAME =
+ OzoneManagerDoubleBufferMetrics.class.getSimpleName();
+
+ @Metric(about = "Total Number of flush iterations happened in " +
+ "OzoneManagerDoubleBuffer.")
+ private MutableCounterLong totalNumOfFlushIterations;
Review comment:
Named this as totalNumOfFlushIterations because we have one more metric
which says maxNumberOfTransactionsFlushedInOneIteration. This will say till
this point what this the maximum number of transactions flushed in a iteration.
If I change the totalNumOfFlushIterations one as totalnumOfFlushOperations, do
you want to change maxNumberOfTransactionsFlushedInOneIteration to some other
name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 260765)
Time Spent: 2.5h (was: 2h 20m)
> Create OMDoubleBuffer metrics
> -----------------------------
>
> Key: HDDS-1579
> URL: https://issues.apache.org/jira/browse/HDDS-1579
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> This Jira is to implement OMDoubleBuffer metrics, to show metrics like.
> # flushIterations.
> # totalTransactionsflushed.
>
> Any other related metrics. This Jira is created based on the comment by
> [~anu] during HDDS-1512 review.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
