[
https://issues.apache.org/jira/browse/HDDS-1694?focusedWorklogId=261741&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261741
]
ASF GitHub Bot logged work on HDDS-1694:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jun/19 19:57
Start Date: 17/Jun/19 19:57
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #978:
HDDS-1694. TestNodeReportHandler is failing with NPE
URL: https://github.com/apache/hadoop/pull/978#discussion_r294491156
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -221,9 +221,8 @@ public VersionResponse getVersion(SCMVersionRequestProto
versionRequest) {
return VersionResponse.newBuilder()
.setVersion(this.version.getVersion())
.addValue(OzoneConsts.SCM_ID,
- this.scmManager.getScmStorageConfig().getScmId())
- .addValue(OzoneConsts.CLUSTER_ID, this.scmManager.getScmStorageConfig()
- .getClusterID())
+ this.scmStorageConfig.getScmId())
+ .addValue(OzoneConsts.CLUSTER_ID, this.scmStorageConfig.getClusterID())
Review comment:
Minor: We can use clusterID which is set in SCMNodeManager constructor. Or
remove the clusterID and use that from scmStorage. I feel 2nd option will be
good, as to get ScmId we got from scmStorageConfig
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 261741)
Time Spent: 50m (was: 40m)
> TestNodeReportHandler is failing with NPE
> -----------------------------------------
>
> Key: HDDS-1694
> URL: https://issues.apache.org/jira/browse/HDDS-1694
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: SCM
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code:java}
> FAILURE in
> ozone-unit-076618677d39x4h9/unit/hadoop-hdds/server-scm/org.apache.hadoop.hdds.scm.node.TestNodeReportHandler.txt
> -------------------------------------------------------------------------------
> Test set: org.apache.hadoop.hdds.scm.node.TestNodeReportHandler
> -------------------------------------------------------------------------------
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.43 s <<<
> FAILURE! - in org.apache.hadoop.hdds.scm.node.TestNodeReportHandler
> testNodeReport(org.apache.hadoop.hdds.scm.node.TestNodeReportHandler) Time
> elapsed: 0.288 s <<< ERROR!
> java.lang.NullPointerException
> at
> org.apache.hadoop.hdds.scm.node.SCMNodeManager.<init>(SCMNodeManager.java:122)
> at
> org.apache.hadoop.hdds.scm.node.TestNodeReportHandler.resetEventCollector(TestNodeReportHandler.java:53)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> at
> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
> 2019-06-16 23:52:29,345 INFO node.SCMNodeManager
> (SCMNodeManager.java:<init>(119)) - Entering startup safe mode.
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
