[
https://issues.apache.org/jira/browse/HDDS-1670?focusedWorklogId=261832&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-261832
]
ASF GitHub Bot logged work on HDDS-1670:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Jun/19 21:34
Start Date: 17/Jun/19 21:34
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #954:
HDDS-1670. Add limit support to /api/containers and /api/containers/{id}
endpoints
URL: https://github.com/apache/hadoop/pull/954#discussion_r294527606
##########
File path:
hadoop-ozone/ozone-recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestContainerKeyService.java
##########
@@ -200,56 +201,67 @@ protected void configure() {
@Test
public void testGetKeysForContainer() {
- Response response = containerKeyService.getKeysForContainer(1L);
+ Response response = containerKeyService.getKeysForContainer(1L, 2);
Collection<KeyMetadata> keyMetadataList =
(Collection<KeyMetadata>) response.getEntity();
- assertTrue(keyMetadataList.size() == 2);
+ assertEquals(keyMetadataList.size(), 2);
Review comment:
Can we add tests with default value of limit also?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 261832)
Time Spent: 3h (was: 2h 50m)
> Add limit support to /api/containers and /api/containers/{id} endpoints
> -----------------------------------------------------------------------
>
> Key: HDDS-1670
> URL: https://issues.apache.org/jira/browse/HDDS-1670
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
> Affects Versions: 0.4.0
> Reporter: Vivek Ratnavel Subramanian
> Assignee: Vivek Ratnavel Subramanian
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Add support for limit query param to limit the results of /api/containers and
> /api/containers/\{id} endpoints
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
