[
https://issues.apache.org/jira/browse/HDDS-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16868728#comment-16868728
]
Eric Yang commented on HDDS-1554:
---------------------------------
[~elek] {quote}This code tries to check the safe mode. Actually we are not
interested about the safe mode here, as SCM can't be started (or shouldn't be
started) with read only directory.
The other problem with this code fragment that you assume that the safe mode is
true in case of any exception. In case of any exception you wait 60 seconds in
the tests without checking what is exactly the problem.{quote}
If scmClient.inSafeMode API is written correctly, SafeMode should never being
set to false. The test case is default safeMode to true even when SCM is
offline. Unless SCM returned improper value instead of throwing connection
error. SafeMode should never be set to false. This is a good test to show
that there is a problem with scm client.
> Create disk tests for fault injection test
> ------------------------------------------
>
> Key: HDDS-1554
> URL: https://issues.apache.org/jira/browse/HDDS-1554
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: build
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Major
> Labels: pull-request-available
> Attachments: HDDS-1554.001.patch, HDDS-1554.002.patch,
> HDDS-1554.003.patch, HDDS-1554.004.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The current plan for fault injection disk tests are:
> # Scenario 1 - Read/Write test
> ## Run docker-compose to bring up a cluster
> ## Initialize scm and om
> ## Upload data to Ozone cluster
> ## Verify data is correct
> ## Shutdown cluster
> # Scenario 2 - Read/Only test
> ## Repeat Scenario 1
> ## Mount data disk as read only
> ## Try to write data to Ozone cluster
> ## Validate error message is correct
> ## Shutdown cluster
> # Scenario 3 - Corruption test
> ## Repeat Scenario 2
> ## Shutdown cluster
> ## Modify data disk data
> ## Restart cluster
> ## Validate error message for read from corrupted data
> ## Validate error message for write to corrupted volume
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
