[
https://issues.apache.org/jira/browse/HDFS-14585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16869208#comment-16869208
]
Lisheng Sun edited comment on HDFS-14585 at 6/21/19 6:03 AM:
-------------------------------------------------------------
[~jojochuang] Thanks for your review.
{quote}Suggest to update the jira summary, as this is essentially a
reimplementation of HDFS-8901 for replicated blocks. Hadoop 2 does not support
EC, and so there's no need to support striped blocks. How about "Reimplement
HDFS-8901 for replicated block positional read in branch-2"?
Do we need any test? Or is this purely an performance improvement and existing
tests cover it all?
{quote}
I issue this Jira is that HBase wishes HDFS-3246 is supported in
branch-2.8.x. HDFS-14483 is that backport HDFS-3246 ByteBuffer pread interface
to branch-2.8.x. But HDFS-14483 is blocked by not supporting ByteBuffer in
DFSInputStream. HDFS-8901 support ByteBuffer in DFSInputStream. So I issue
this Jira that only backport part of the conent of HDFS-8901 about byte[] to
ByteBuffer.
And the existing tests cover it all, and I do unit test. Thank you.
Could you suggest this issue to branch-2 or HDFS-14483 direct support
ByteBuffer in DFSInputStream?
was (Author: leosun08):
[~jojochuang] Thanks for your review.
{quote}Suggest to update the jira summary, as this is essentially a
reimplementation of HDFS-8901 for replicated blocks. Hadoop 2 does not support
EC, and so there's no need to support striped blocks. How about "Reimplement
HDFS-8901 for replicated block positional read in branch-2"?
Do we need any test? Or is this purely an performance improvement and existing
tests cover it all?
{quote}
I issue this Jira is that HBase wishes HDFS-3246 is supported in
branch-2.8.x. HDFS-14483 is that backport HDFS-3246 ByteBuffer pread interface
to branch-2.8.x. But HDFS-14483 is blocked by not supporting ByteBuffer in
DFSInputStream. HDFS-8901 support ByteBuffer in DFSInputStream. So I issue
this Jira that only backport part of the conent of HDFS-8901 about byte[] to
ByteBuffer.
And the existing tests cover it all, and I do unit test. Thank you.
> Backport HDFS-8901 Use ByteBuffer in striping positional read to branch-2.8.x
> -----------------------------------------------------------------------------
>
> Key: HDFS-14585
> URL: https://issues.apache.org/jira/browse/HDFS-14585
> Project: Hadoop HDFS
> Issue Type: Task
> Reporter: Lisheng Sun
> Assignee: Lisheng Sun
> Priority: Major
> Attachments: HDFS-14585.branch-2.8.v1.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
