[
https://issues.apache.org/jira/browse/HDDS-1723?focusedWorklogId=265158&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-265158
]
ASF GitHub Bot logged work on HDDS-1723:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Jun/19 02:02
Start Date: 22/Jun/19 02:02
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1006: HDDS-1723.
Create new OzoneManagerLock class.
URL: https://github.com/apache/hadoop/pull/1006#issuecomment-504617781
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 70 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 2 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 69 | Maven dependency ordering for branch |
| +1 | mvninstall | 484 | trunk passed |
| +1 | compile | 247 | trunk passed |
| +1 | checkstyle | 67 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 891 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 157 | trunk passed |
| 0 | spotbugs | 330 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 642 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 31 | Maven dependency ordering for patch |
| +1 | mvninstall | 446 | the patch passed |
| +1 | compile | 263 | the patch passed |
| +1 | javac | 263 | the patch passed |
| -0 | checkstyle | 40 | hadoop-ozone: The patch generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 739 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 164 | the patch passed |
| -1 | findbugs | 314 | hadoop-ozone generated 1 new + 0 unchanged - 0 fixed
= 1 total (was 0) |
||| _ Other Tests _ |
| +1 | unit | 264 | hadoop-hdds in the patch passed. |
| -1 | unit | 1305 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 43 | The patch does not generate ASF License warnings. |
| | | 6637 | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-ozone |
| | org.apache.hadoop.ozone.om.lock.OzoneManagerLock.lambda$new$0()
invokes inefficient new Short(short) constructor; use Short.valueOf(short)
instead At OzoneManagerLock.java:constructor; use Short.valueOf(short) instead
At OzoneManagerLock.java:[line 62] |
| Failed junit tests | hadoop.ozone.client.rpc.TestBCSID |
| | hadoop.ozone.client.rpc.TestOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestSecureOzoneRpcClient |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
| | hadoop.ozone.client.rpc.TestFailureHandlingByClient |
| | hadoop.ozone.client.rpc.TestOzoneAtRestEncryption |
| | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=18.09.5 Server=18.09.5 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1006 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 80bd016d9872 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3
08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 371452e |
| Default Java | 1.8.0_212 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/artifact/out/diff-checkstyle-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/artifact/out/new-findbugs-hadoop-ozone.html
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/testReport/ |
| Max. process+thread count | 5017 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-ozone/common U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1006/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 265158)
Time Spent: 40m (was: 0.5h)
> Create new OzoneManagerLock class
> ---------------------------------
>
> Key: HDDS-1723
> URL: https://issues.apache.org/jira/browse/HDDS-1723
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Ozone Manager
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This Jira is to use bit manipulation, instead of hashmap in OzoneManager lock
> logic. And also this Jira follows the locking order based on the document
> attached to HDDS-1672 jira.
> This Jira is created based on [~anu] comment during review of HDDS-1672.
> Not a suggestion for this patch. But more of a question, should we just
> maintain a bitset here, and just flip that bit up and down to see if the lock
> is held. Or we can just maintain 32 bit integer, and we can easily find if a
> lock is held by Xoring with the correct mask. I feel that might be super
> efficient. [@nandakumar131|https://github.com/nandakumar131] . But as I said
> let us not do that in this patch.
>
> This Jira will add new class, integration of this new class into code will be
> done in a new jira.
> Clean up of old code also will be done in new jira.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
