[
https://issues.apache.org/jira/browse/HDDS-373?focusedWorklogId=269639&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269639
]
ASF GitHub Bot logged work on HDDS-373:
---------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jun/19 00:19
Start Date: 29/Jun/19 00:19
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1025:
HDDS-373. Genconf tool must generate ozone-site.xml with sample values
URL: https://github.com/apache/hadoop/pull/1025#discussion_r298779284
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/genconf/GenerateOzoneRequiredConfigurations.java
##########
@@ -106,9 +109,19 @@ public static void generateConfigurations(String path)
throws
for (OzoneConfiguration.Property p : allProperties) {
if (p.getTag() != null && p.getTag().contains("REQUIRED")) {
- if(p.getName().equalsIgnoreCase(OzoneConfigKeys.OZONE_ENABLED)) {
+ if (p.getName().equalsIgnoreCase(OzoneConfigKeys.OZONE_ENABLED)) {
p.setValue(String.valueOf(Boolean.TRUE));
+ } else if (p.getName().equalsIgnoreCase(
+ OzoneConfigKeys.OZONE_METADATA_DIRS)) {
+ p.setValue(System.getProperty(OzoneConsts.JAVA_TMP_DIR));
+ } else if (p.getName().equalsIgnoreCase(
Review comment:
This will be for local one node cluster?
As when HA comes, this will not work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 269639)
Time Spent: 50m (was: 40m)
> Genconf tool must generate ozone-site.xml with sample values
> ------------------------------------------------------------
>
> Key: HDDS-373
> URL: https://issues.apache.org/jira/browse/HDDS-373
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: Tools
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Labels: pull-request-available
> Attachments: HDDS-373.001.patch
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> As discussed with [~anu], currently, the genconf tool generates a template
> ozone-site.xml. This is not very useful for new users as they would have to
> understand what values should be set for the minimal configuration properties.
> This Jira proposes to modify the ozone-default.xml which is leveraged by
> genconf tool to generate ozone-site.xml
>
> Further, as suggested by [~arpitagarwal], we must add a {{--pseudo}} option
> to generate configs for starting pseudo-cluster. This should be useful for
> quick dev-testing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
