[
https://issues.apache.org/jira/browse/HDDS-1728?focusedWorklogId=270791&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-270791
]
ASF GitHub Bot logged work on HDDS-1728:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/19 11:21
Start Date: 02/Jul/19 11:21
Worklog Time Spent: 10m
Work Description: lokeshj1703 commented on pull request #1022: HDDS-1728.
Add metrics for leader's latency in ContainerStateMachine. Contributed by Mukul
Kumar Singh.
URL: https://github.com/apache/hadoop/pull/1022#discussion_r299425652
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/CSMMetrics.java
##########
@@ -43,14 +46,28 @@
private @Metric MutableCounterLong numBytesWrittenCount;
private @Metric MutableCounterLong numBytesCommittedCount;
+ private @Metric MutableRate transactionLatency;
+ private MutableRate[] opsLatency;
+ private MetricsRegistry registry = null;
+
// Failure Metrics
private @Metric MutableCounterLong numWriteStateMachineFails;
private @Metric MutableCounterLong numQueryStateMachineFails;
private @Metric MutableCounterLong numApplyTransactionFails;
private @Metric MutableCounterLong numReadStateMachineFails;
private @Metric MutableCounterLong numReadStateMachineMissCount;
+ private @Metric MutableCounterLong numStartTransactionVerifyFailures;
+ private @Metric MutableCounterLong numContainerNotOpenVerifyFailures;
public CSMMetrics() {
+ int numEnumEntries = ContainerProtos.Type.values().length;
+ this.opsLatency = new MutableRate[numEnumEntries];
+ this.registry = new MetricsRegistry("CSMMetrics");
Review comment:
We can use CSMMetrics.class.getName() here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 270791)
Time Spent: 40m (was: 0.5h)
> Add metrics for leader's latency in ContainerStateMachine
> ---------------------------------------------------------
>
> Key: HDDS-1728
> URL: https://issues.apache.org/jira/browse/HDDS-1728
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Affects Versions: 0.4.0
> Reporter: Mukul Kumar Singh
> Assignee: Mukul Kumar Singh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This jira proposes to add metrics around leaders round trip reply to ratis
> client. This will be done via startTransaction api
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
