[
https://issues.apache.org/jira/browse/HDDS-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877283#comment-16877283
]
Eric Yang commented on HDDS-1734:
---------------------------------
{quote}can you tell me case where we have use case for this ?{quote}
If Dockerfile has older timestamp in source directory, it may not get
regenerated. This may happen if developer copy the file from another location
which he actively doing development from or the file is shared by another
developer. He can't run mvn clean because he would have to build the full
Ozone source to get some of the jar dependencies.
{quote}Until this is fixed in Hadoop, I am not comfortable doing this for Ozone
and I am -1; Just being risk-averse since we are focused on getting to a Beta
and GA for Ozone. So let us not do something that has no clear value over the
current way. Your best argument is that we will be the same after committing
this patch. I am not sure we want to do that.{quote}
The goal is to have ability to create tarball and store the tarball in maven
repository. This is good for repeatability. I respect your decision, if you
see no value in this patch.
> Use maven assembly to create ozone tarball image
> ------------------------------------------------
>
> Key: HDDS-1734
> URL: https://issues.apache.org/jira/browse/HDDS-1734
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Eric Yang
> Assignee: Eric Yang
> Priority: Major
> Attachments: HDDS-1734.001.patch, HDDS-1734.002.patch,
> HDDS-1734.003.patch
>
>
> Ozone is using tar stitching to create ozone tarball. This prevents down
> stream project to use Ozone tarball as a dependency. It would be nice to
> create Ozone tarball with maven assembly plugin to have ability to cache
> ozone tarball in maven repository. This ability allows docker build to be a
> separate sub-module and referencing to Ozone tarball. This change can help
> docker development to be more agile without making a full project build.
> Test procedure:
> {code:java}
> mvn -f pom.ozone.xml clean install -DskipTests -DskipShade
> -Dmaven.javadoc.skip -Pdist{code}
> Expected result:
> This will install tarball into:
> {code:java}
> ~/.m2/repository/org/apache/hadoop/hadoop-ozone-dist/0.5.0-SNAPSHOT/hadoop-ozone-dist-0.5.0-SNAPSHOT.tar.gz{code}
> Test procedure 2:
> {code:java}
> mvn -f pom.ozone.xml clean package -DskipTests -DskipShade
> -Dmaven.javadoc.skip -Pdist{code}
>
> Expected result:
> hadoop/hadoop-ozone/dist/target directory contains
> ozone-0.5.0-SNAPSHOT.tar.gz file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
