[
https://issues.apache.org/jira/browse/HDDS-1731?focusedWorklogId=271240&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-271240
]
ASF GitHub Bot logged work on HDDS-1731:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Jul/19 21:49
Start Date: 02/Jul/19 21:49
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1044:
HDDS-1731. Implement File CreateFile Request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1044#discussion_r299699515
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCreateRequest.java
##########
@@ -162,73 +164,88 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
KeyArgs keyArgs = createKeyRequest.getKeyArgs();
-
String volumeName = keyArgs.getVolumeName();
String bucketName = keyArgs.getBucketName();
String keyName = keyArgs.getKeyName();
OMMetrics omMetrics = ozoneManager.getMetrics();
omMetrics.incNumKeyAllocates();
- AuditLogger auditLogger = ozoneManager.getAuditLogger();
-
- Map<String, String> auditMap = buildKeyArgsAuditMap(keyArgs);
-
- OMResponse.Builder omResponse = OMResponse.newBuilder().setCmdType(
- OzoneManagerProtocolProtos.Type.CreateKey).setStatus(
- OzoneManagerProtocolProtos.Status.OK).setSuccess(true);
-
+ OMMetadataManager omMetadataManager = ozoneManager.getMetadataManager();
+ OmKeyInfo omKeyInfo = null;
+ final List< OmKeyLocationInfo > locations = new ArrayList<>();
+ FileEncryptionInfo encryptionInfo = null;
+ IOException exception = null;
+ boolean acquireLock = false;
Review comment:
Done. during refactoring things for OMFileCreateRequest, missed acquiring
lock. Added that back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 271240)
Time Spent: 2h 50m (was: 2h 40m)
> Implement File CreateFile Request to use Cache and DoubleBuffer
> ---------------------------------------------------------------
>
> Key: HDDS-1731
> URL: https://issues.apache.org/jira/browse/HDDS-1731
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> In this Jira, we shall implement createFile request according to the HA
> model, and use cache and double buffer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
