[ 
https://issues.apache.org/jira/browse/HDDS-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16877333#comment-16877333
 ] 

Anu Engineer edited comment on HDDS-1735 at 7/2/19 10:34 PM:
-------------------------------------------------------------

Exactly what I predicted. You chickened out. So here is the answer from the 
Ozone side.

I just ran this analysis on HDDS. I have 3 find bug issues, and 2 of them are 
experimental in Findbugs itself. I am using the latest find bugs. 

Obviously, you don't dare to do it on Hadoop or Common since your lies will be 
exposed.

Since you so blatantly bad mouth other people, and do no work; I am expecting 
that you did not look at any of the Suppress annotations either. I did;

 As for the suppressFBWarning, Each one of them was written by a developer 
making a conscious decision; not by someone running a grep. if you think a 
specific case is wrong; you should tag that as a Jira, oh – but that requires 
work. Which is not your specialty; but useless trolling is, and if I ask you 
for a measurement; you will not provide that; since that will again expose how 
dishonest your comments are.

I will upload my screenshot; if you want to continue this discussion; produce 
the measurements on your side; otherwise I am going to presume that you have 
been called out on your dishonest/malicious/ignorant comments; I am not sure 
what the root cause is;

 

 


was (Author: anu):
Exactly what I predicted. You chickened out. So here is the answer from the 
Ozone side.

I just ran this analysis on HDDS. I have 3 find bug issues, and 2 of them are 
experimental in Findbugs itself. I am using the latest find bugs. 

Obviously, you don't dare to do it on Hadoop or Common since your lies will be 
exposed.

Since you so blatantly bad mouth other people, and do no work; I am expecting 
that you did not look at any of the Suppress annotations either. I did;

 As for the suppressFBWarning, Each one of them was written by a developer 
making a conscious decision; not by someone running a grep. if you think a 
specific case is wrong; you should tag that as a Jira, oh – but that requires 
work. Which is not your specialty; but useless trolling is, and if I ask you 
for a measurement; you will not provide that; since that will again expose who 
much dishonest your comments are.

I will upload my screenshot; if you want to continue this discussion; produce 
the measurements on your side; otherwise I am going to presume that you have 
been called out on your dishonest/malicious/ignorant comments; I am not sure 
what the root cause is;

 

 

> Create separate unit and integration test executor dev-support script
> ---------------------------------------------------------------------
>
>                 Key: HDDS-1735
>                 URL: https://issues.apache.org/jira/browse/HDDS-1735
>             Project: Hadoop Distributed Data Store
>          Issue Type: Improvement
>            Reporter: Elek, Marton
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: pull-request-available
>         Attachments: Screen Shot 2019-07-02 at 3.25.33 PM.png
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> hadoop-ozone/dev-support/checks directory contains multiple helper script to 
> execute different type of testing (findbugs, rat, unit, build).
> They easily define how tests should be executed, with the following contract:
>  * The problems should be printed out to the console
>  * in case of test failure a non zero exit code should be used
>  
> The tests are working well (in fact I have some experiments with executing 
> these scripts on k8s and argo where all the shell scripts are executed 
> parallel) but we need some update:
>  1. Most important: the unit tests and integration tests can be separated. 
> Integration tests are more flaky and it's better to have a way to run only 
> the normal unit tests
>  2. As HDDS-1115 introduced a pom.ozone.xml it's better to use them instead 
> of the magical "am pl hadoop-ozone-dist" trick--
>  3. To make it possible to run blockade test in containers we should use - T 
> flag with docker-compose
>  4. checkstyle violations are printed out to the console



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to