[
https://issues.apache.org/jira/browse/HDDS-1731?focusedWorklogId=271752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-271752
]
ASF GitHub Bot logged work on HDDS-1731:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/19 17:26
Start Date: 03/Jul/19 17:26
Worklog Time Spent: 10m
Work Description: arp7 commented on issue #1044: HDDS-1731. Implement
File CreateFile Request to use Cache and DoubleBuffer.
URL: https://github.com/apache/hadoop/pull/1044#issuecomment-508183660
The patch looks mostly fine to me. A few minor comments. ~~and one type
error that needs to be fixed.~~
I would like to see the class hierarchy refactored in a follow up patch.
`OMFileCreateRequest` should not extend `OMKeyCreateRequest`. Instead they
should both extend an abstract class that encapsulates the common functionality.
Generally deriving from _concrete_ classes is a bad idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 271752)
Time Spent: 5h (was: 4h 50m)
> Implement File CreateFile Request to use Cache and DoubleBuffer
> ---------------------------------------------------------------
>
> Key: HDDS-1731
> URL: https://issues.apache.org/jira/browse/HDDS-1731
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
> In this Jira, we shall implement createFile request according to the HA
> model, and use cache and double buffer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
