[
https://issues.apache.org/jira/browse/HDDS-1735?focusedWorklogId=272267&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-272267
]
ASF GitHub Bot logged work on HDDS-1735:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/19 15:47
Start Date: 04/Jul/19 15:47
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1035: HDDS-1735.
Create separate unit and integration test executor dev-support script
URL: https://github.com/apache/hadoop/pull/1035#issuecomment-508524307
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 32 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| 0 | shelldocs | 0 | Shelldocs was not available. |
| 0 | @author | 0 | Skipping @author checks as author.sh has been patched. |
| +1 | test4tests | 0 | The patch appears to include 1 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 52 | Maven dependency ordering for branch |
| +1 | mvninstall | 482 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| -1 | pylint | 5 | Error running pylint. Please check pylint stderr files. |
| +1 | shadedclient | 783 | branch has no errors when building and testing
our client artifacts. |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 22 | Maven dependency ordering for patch |
| +1 | mvninstall | 431 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| -1 | pylint | 6 | Error running pylint. Please check pylint stderr files. |
| +1 | pylint | 6 | There were no new pylint issues. |
| +1 | shellcheck | 0 | The patch generated 0 new + 0 unchanged - 7 fixed =
0 total (was 7) |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 703 | patch has no errors when building and testing
our client artifacts. |
||| _ Other Tests _ |
| +1 | unit | 104 | hadoop-hdds in the patch passed. |
| +1 | unit | 176 | hadoop-ozone in the patch passed. |
| +1 | asflicense | 48 | The patch does not generate ASF License warnings. |
| | | 3007 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=17.05.0-ce Server=17.05.0-ce base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1035/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1035 |
| Optional Tests | dupname asflicense mvnsite unit shellcheck shelldocs
pylint |
| uname | Linux 2c4cf55cdab1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2
17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 1c254a8 |
| pylint |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1035/2/artifact/out/branch-pylint-stderr.txt
|
| pylint |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1035/2/artifact/out/patch-pylint-stderr.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1035/2/testReport/ |
| Max. process+thread count | 444 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone hadoop-ozone/fault-injection-test/network-tests
U: hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1035/2/console |
| versions | git=2.7.4 maven=3.3.9 shellcheck=0.4.6 pylint=1.9.2 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 272267)
Time Spent: 1h 20m (was: 1h 10m)
> Create separate unit and integration test executor dev-support script
> ---------------------------------------------------------------------
>
> Key: HDDS-1735
> URL: https://issues.apache.org/jira/browse/HDDS-1735
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Elek, Marton
> Assignee: Elek, Marton
> Priority: Major
> Labels: pull-request-available
> Attachments: Screen Shot 2019-07-02 at 3.25.33 PM.png
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> hadoop-ozone/dev-support/checks directory contains multiple helper script to
> execute different type of testing (findbugs, rat, unit, build).
> They easily define how tests should be executed, with the following contract:
> * The problems should be printed out to the console
> * in case of test failure a non zero exit code should be used
>
> The tests are working well (in fact I have some experiments with executing
> these scripts on k8s and argo where all the shell scripts are executed
> parallel) but we need some update:
> 1. Most important: the unit tests and integration tests can be separated.
> Integration tests are more flaky and it's better to have a way to run only
> the normal unit tests
> 2. As HDDS-1115 introduced a pom.ozone.xml it's better to use them instead
> of the magical "am pl hadoop-ozone-dist" trick--
> 3. To make it possible to run blockade test in containers we should use - T
> flag with docker-compose
> 4. checkstyle violations are printed out to the console
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
