[
https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879446#comment-16879446
]
Íñigo Goiri edited comment on HDFS-14593 at 7/5/19 5:40 PM:
------------------------------------------------------------
Thanks [~tasanuma], some comments:
* I think we can make the method in BaseRecord return -1 by default so we don't
need to tweak all the subclasses.
* BaseRecord#shouldBeDeleted() with the summations looks a little weird to
read, can we expand the if condition and the summation to make it more readable?
* We may want to keep supporting 0 for expiration as in
MountTable#getExpirationMs().
* Having to sleep 11 seconds for the expiration is a little too much; can we
make this tighter?
* The ZK unit tests looks related.
was (Author: elgoiri):
* I think we can make the method in BaseRecord return -1 by default so we don't
need to tweak all the subclasses.
* BaseRecord#shouldBeDeleted() with the summations looks a little weird to
read, can we expand the if condition and the summation to make it more readable?
* We may want to keep supporting 0 for expiration as in
MountTable#getExpirationMs().
* Having to sleep 11 seconds for the expiration is a little too much; can we
make this tighter?
> RBF: RouterAdmin should be able to remove expired routers from Routers
> Information
> ----------------------------------------------------------------------------------
>
> Key: HDFS-14593
> URL: https://issues.apache.org/jira/browse/HDFS-14593
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Major
> Attachments: HDFS-14593.001.patch, HDFS-14593.002.patch,
> HDFS-14593.003.patch
>
>
> Currently, any router seems to exist in the Router Information eternally.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
