[
https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880475#comment-16880475
]
Takanobu Asanuma commented on HDFS-14593:
-----------------------------------------
Thanks for your review, [~elgoiri]! Uploaded the 4th patch addressing your
comments.
{quote}BaseRecord#shouldBeDeleted()
{quote}
Instead of checking positive time in the 3rd patch, the 4th patch checks
whether the status is expired or not (and the deletion is enabled or not). This
is more accurate of the definition of this feature. (The 3rd patch can delete
non-expired records.)
{quote}The ZK unit tests looks related.
{quote}
Yes, it does. Since expired record doesn't update the modification time, a
comparison in the unit test failed. The patch simply skips the comparison of
the expired record.
> RBF: RouterAdmin should be able to remove expired routers from Routers
> Information
> ----------------------------------------------------------------------------------
>
> Key: HDFS-14593
> URL: https://issues.apache.org/jira/browse/HDFS-14593
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Components: rbf
> Reporter: Takanobu Asanuma
> Assignee: Takanobu Asanuma
> Priority: Major
> Attachments: HDFS-14593.001.patch, HDFS-14593.002.patch,
> HDFS-14593.003.patch, HDFS-14593.004.patch
>
>
> Currently, any router seems to exist in the Router Information eternally.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
