[
https://issues.apache.org/jira/browse/HDDS-1585?focusedWorklogId=274052&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274052
]
ASF GitHub Bot logged work on HDDS-1585:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/19 13:33
Start Date: 09/Jul/19 13:33
Worklog Time Spent: 10m
Work Description: elek commented on issue #1064: HDDS-1585. Add
LICENSE.txt and NOTICE.txt to Ozone Recon Web
URL: https://github.com/apache/hadoop/pull/1064#issuecomment-509644160
Thanks the patch @vivekratnavel
I like the approach to generate the licence content with yarn licence. Looks
good to me.
But (AFAIK) the LICENSE should be added to the top level LICENSE.txt file of
the binary package (or should be referenced from the top level LICENSE.txt).
As of now we use the main LICENSE.txt from the source root:
{code}
cat hadoop-ozone/dist/dev-support/bin/dist-layout-stitching
#...
run cp -p "${ROOT}/LICENSE.txt"
#...
{code}
AFAIK there are two options:
1. Option one:
* Put the generate license to the root as LICENSE.ozone-recon.txt
* Add some text to the LICENSE.txt which points to the new file
* Both files should be copied to all the distributions (hadoop, ozone)
2. Option two (better)
The problem with the first approach is that we add a reference to the recon
licenses even if we have no recon in the package (eg in hadoop package.)
A better approach could be to:
* Copy existing LICENSE.txt to the hadoop-ozone/dist/....
* Use it for the ozone binary package (modify dist-layout-stitching)
* Add reference to the recon txt file (LICENSE.txt)
* Include recon license file in the binary package (modify
dist-layout-stitching)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 274052)
Time Spent: 20h (was: 19h 50m)
> Add LICENSE.txt and NOTICE.txt to Ozone Recon Web
> -------------------------------------------------
>
> Key: HDDS-1585
> URL: https://issues.apache.org/jira/browse/HDDS-1585
> Project: Hadoop Distributed Data Store
> Issue Type: Task
> Components: Ozone Recon
> Affects Versions: 0.4.0
> Reporter: Vivek Ratnavel Subramanian
> Assignee: Vivek Ratnavel Subramanian
> Priority: Blocker
> Labels: pull-request-available
> Time Spent: 20h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
