[ 
https://issues.apache.org/jira/browse/HDFS-14593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16881685#comment-16881685
 ] 

Takanobu Asanuma edited comment on HDFS-14593 at 7/10/19 3:22 AM:
------------------------------------------------------------------

Thanks for your review, [~elgoiri].

If not changing the order, expired records keep existing in the 
cache({{result}} at {{CachedRecordStore#118}}) after deleting them from State 
Store by {{overrideExpiredRecords()}}. Then, they are deleted from the cache in 
the next loadCache.
If changing the order, they are deleted from both State Store and the cache at 
the same loadCache. I think changing the order is more accurate.

Indeed, we should move the timestamp too. Uploaded 006.patch addressing it.


was (Author: tasanuma0829):
Thanks for your review, [~elgoiri].

If not changing the order, expired records keep existing in the 
cache({{result}} at {{CachedRecordStore#118}}) after deleting them by 
{{overrideExpiredRecords()}}. Then, they are deleted from the cache in the next 
loadCache. I think changing the order is more accurate.

Indeed, we should move the timestamp too. Uploaded 006.patch addressing it.

> RBF: Implement deletion feature for expired records in State Store
> ------------------------------------------------------------------
>
>                 Key: HDFS-14593
>                 URL: https://issues.apache.org/jira/browse/HDFS-14593
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: rbf
>            Reporter: Takanobu Asanuma
>            Assignee: Takanobu Asanuma
>            Priority: Major
>         Attachments: HDFS-14593.001.patch, HDFS-14593.002.patch, 
> HDFS-14593.003.patch, HDFS-14593.004.patch, HDFS-14593.005.patch, 
> HDFS-14593.006.patch
>
>
> Currently, any router seems to exist in the Router Information eternally.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to